-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Icon links should be evenly distributed #1720
Comments
seems like a good idea to me. @gabalafou @12rambau any reason you can think of why we might not want that? |
In what context fdo you see these lines ? Is it in the right sidebar on small screen or on the top navbar on big ones ? |
I don't know what lines you're referring to? This proposal is about spacing between icon links |
I believe @12rambau refers to the display shown in your images where the icons and the search field are presented in a two row layout (icons on top of search) |
yep, because if it's the left sidebar then I prefer to have them left align as th text. If its the top navbar I'm don't have strong opinion. You'll note that I have no other argument than "I prefer" so if any a11y justification comes in, please do as if I wasn't there ;-) |
It is the primary sidebar, on the left. |
one thing that occurs to me is that spacing buttons farther apart makes them easier to hit on a touch device with big or shaky fingers --- so that's maybe an argument in favor of spreading them out when they're in the sidebar (which by default happens on small screens, which are usually touch devices). |
I think we have one usability argument in favor, and one "just my opinion, feel free to disregard" vote against. So I'd say please go ahead with a PR @leifwalsh |
Will do, just need to wait for approval to contribute from $work, so probably next week. Thanks! |
(rather than justified left)
I am not sure, whether this might already solve my issue, but I came across a similar problem, when looking at the version-switcher. We are currently preparing multi-version documentation and in this process discuss where to best place the version switcher. One option is to put it into navbar_end next to the icon links. However, then it ends up in the same line as the logos in the primary sidebar on small dveices: As you can see they do not align nicely. While I do not know, whether that would be easy to fix, I would like to suggest to put the version-switcher into a separate line. Again, I have no idea, whether that can ebe easily achieved. |
One more point: when you look carefully, you also realsie, that the font size is different for the version switcher and the other navigation items. |
* space icon-links evenly across #1720 (rather than justified left) * restore column-gap
* space icon-links evenly across pydata#1720 (rather than justified left) * restore column-gap
I think the icon links feature would look better with
justify-content: space-evenly
:Before:
After:
I'm not sure what this looks like with multiple rows of icon links, and maybe someone else knows a better CSS way to do this than I do. But I found that this CSS makes things look better:
The text was updated successfully, but these errors were encountered: