Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to build the test_build themes in CWD (and not tempdir) #1798

Open
Carreau opened this issue May 2, 2024 · 1 comment
Open

Option to build the test_build themes in CWD (and not tempdir) #1798

Carreau opened this issue May 2, 2024 · 1 comment
Labels
kind: enhancement New feature or request tag: testing Issues related to PST testing

Comments

@Carreau
Copy link
Collaborator

Carreau commented May 2, 2024

I think it would be useful to have an option/env variable to not erase the test rendering when running nox -s test, At least I wanted to check a few things and had a hard time figuring out how to get to those (e.g: checking there are enough menu items to have dropdowns).

I'm suggeting PST_BUILD_DIR='.' for example, and if set it would not erase the temp files as well as build in ..
Unless there is an option I have not found.
@trallard trallard added kind: enhancement New feature or request tag: testing Issues related to PST testing labels May 2, 2024
@trallard
Copy link
Collaborator

trallard commented May 2, 2024

This should be part of #1759

Carreau added a commit to Carreau/pydata-sphinx-theme that referenced this issue May 2, 2024
@Carreau
Add env variable to control test-them build location.
037f26f 
I needed this to debug some things, so why not send it as a PR.

See pydata#1798, maybe this should be folded in pydata#1759 ?
Carreau added a commit to Carreau/pydata-sphinx-theme that referenced this issue May 2, 2024
@Carreau
Add env variable to control test-them build location.
9e3a0c4 
I needed this to debug some things, so why not send it as a PR.

See pydata#1798, maybe this should be folded in pydata#1759 ?
@Carreau Carreau mentioned this issue May 2, 2024
Merged
Carreau added a commit to Carreau/pydata-sphinx-theme that referenced this issue May 2, 2024
@Carreau
Add env variable to control test-them build location.
8d6869f 
I needed this to debug some things, so why not send it as a PR.

See pydata#1798, maybe this should be folded in pydata#1759 ?
trallard pushed a commit that referenced this issue May 13, 2024
@Carreau @drammock
MAINT - Add env variable to control test-them build location. (#1800)
64fbfef 
* Add env variable to control test-them build location.

I needed this to debug some things, so why not send it as a PR.

See #1798, maybe this should be folded in #1759 ?

* Update tests/conftest.py

Co-authored-by: Daniel McCloy <dan@mccloy.info>

---------

Co-authored-by: Daniel McCloy <dan@mccloy.info>
ivanov pushed a commit to ivanov/pydata-sphinx-theme that referenced this issue Jun 5, 2024
@Carreau @drammock @ivanov
MAINT - Add env variable to control test-them build location. (pydata…
fd7b9ed 
…#1800)

* Add env variable to control test-them build location.

I needed this to debug some things, so why not send it as a PR.

See pydata#1798, maybe this should be folded in pydata#1759 ?

* Update tests/conftest.py

Co-authored-by: Daniel McCloy <dan@mccloy.info>

---------

Co-authored-by: Daniel McCloy <dan@mccloy.info>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind: enhancement New feature or request tag: testing Issues related to PST testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Carreau @trallard