Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: include jupyterlite in the supported extention #1023

Merged
merged 10 commits into from
May 20, 2023

Conversation

12rambau
Copy link
Collaborator

@12rambau 12rambau commented Oct 18, 2022

#745, Fix #755

It's not working locally and my issue is on stale (jupyterlite/jupyterlite-sphinx#76). I'll try distant build to see if the behaviour improves.

Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI this seems to work on the readthedocs build - are there any specific styles etc you wanted to add? Otherwise I'm +1 on just merging this in as a docs PR and using follow-up issues/PRs to spot-check any specific thing that needs to be improved

@12rambau
Copy link
Collaborator Author

12rambau commented Nov 7, 2022

I have an open issue on their repositiory to understand how to use a file and it will be good to go

@12rambau
Copy link
Collaborator Author

12rambau commented Nov 11, 2022

ok so before making this one ready for review I'm missing a handle to switch the jupyterlite theme when our switcher is modified.

The issue is opened here and I think we should not add it until we have a working set up

@12rambau
Copy link
Collaborator Author

12rambau commented Jan 7, 2023

@choldgraf I would say let's merge this one and keep the color switch issue open (#745). They are using our theme on their side (https://jupyterlite-sphinx.readthedocs.io/en/latest/installation.html) so they will need to add support eventually.

@12rambau 12rambau marked this pull request as ready for review January 7, 2023 15:44
@choldgraf
Copy link
Collaborator

Makes sense to me - are the failing tests real?

@12rambau
Copy link
Collaborator Author

12rambau commented Jan 7, 2023

oh yes, they are. I just added a disclaimer I didn't though I would break anything. It seems to be related to jupyterlite/jupyterlite-sphinx#27 but I need to investigate (the issue is closed on their side)

@12rambau
Copy link
Collaborator Author

@choldgraf as you decided to use MySTNB to parse the pydata.md file, I decided to move the execution libs in their own page so that the display is shown when they are used alone.

@12rambau 12rambau requested a review from choldgraf February 28, 2023 14:23
Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me - just a quick comment on having a clean separation of execution library patterns. LMK what you think.

docs/examples/pydata.md Outdated Show resolved Hide resolved
docs/examples/pydata.md Outdated Show resolved Hide resolved
@12rambau
Copy link
Collaborator Author

It's here for a long time and seems to work, I consider last comment from @choldgraf as a semi-approval. If nobody complains, I'll merge it tomorrow. the styling will be done in a follow-up PR.

@12rambau 12rambau merged commit 9f04c2f into pydata:main May 20, 2023
@12rambau 12rambau deleted the jupyterlab branch May 20, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add JupyterLite to our documentation
2 participants