-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: include jupyterlite in the supported extention #1023
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI this seems to work on the readthedocs build - are there any specific styles etc you wanted to add? Otherwise I'm +1 on just merging this in as a docs PR and using follow-up issues/PRs to spot-check any specific thing that needs to be improved
I have an open issue on their repositiory to understand how to use a file and it will be good to go |
ok so before making this one ready for review I'm missing a handle to switch the jupyterlite theme when our switcher is modified. The issue is opened here and I think we should not add it until we have a working set up |
@choldgraf I would say let's merge this one and keep the color switch issue open (#745). They are using our theme on their side (https://jupyterlite-sphinx.readthedocs.io/en/latest/installation.html) so they will need to add support eventually. |
Makes sense to me - are the failing tests real? |
oh yes, they are. I just added a disclaimer I didn't though I would break anything. It seems to be related to jupyterlite/jupyterlite-sphinx#27 but I need to investigate (the issue is closed on their side) |
@choldgraf as you decided to use MySTNB to parse the pydata.md file, I decided to move the execution libs in their own page so that the display is shown when they are used alone. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me - just a quick comment on having a clean separation of execution library patterns. LMK what you think.
It's here for a long time and seems to work, I consider last comment from @choldgraf as a semi-approval. If nobody complains, I'll merge it tomorrow. the styling will be done in a follow-up PR. |
#745, Fix #755
It's not working locally and my issue is on stale (jupyterlite/jupyterlite-sphinx#76). I'll try distant build to see if the behaviour improves.