Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added @brightway-lca documentation to example gallery #1119

Closed
wants to merge 1 commit into from
Closed

added @brightway-lca documentation to example gallery #1119

wants to merge 1 commit into from

Conversation

michaelweinold
Copy link
Contributor

No description provided.

Copy link
Collaborator

@12rambau 12rambau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for contributing to our theme and thanks for choosing pydata-sphinx-theme for your new documentation.

At the moment, the link you added is the draft of your documentation and some things still require some tuning (your API references includes tests and setup.py which is I think not intended). I would suggest to wait until this becomes the stable documentation before adding it to the gallery.

Also you need to add the name of your image to this file (

WARNING: image file not readable: _static/gallery/matplotlib.png
) as the thumbnails are not downloaded in CI (too long).

@michaelweinold
Copy link
Contributor Author

Thank you for the quick response - I will update the PR once our API documentation has been updated and our 'legacy' documentation is offline in favour of the new pydata-sphinx page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants