Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove Site navigation header #1615

Merged
merged 2 commits into from
Jan 4, 2024
Merged

fix: remove Site navigation header #1615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d800d47
fix: remove Site navigation header
12rambau Jan 3, 2024
f76eff4
test: edit the test suit
12rambau Jan 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 0 additions & 5 deletions src/pydata_sphinx_theme/assets/styles/components/_navbar-links.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,3 @@
}
}
}

// Don't display the `site navigation` in the header menu
.bd-header .navbar-nav > p.sidebar-header-items__title {
display: none;
}
6 changes: 0 additions & 6 deletions src/pydata_sphinx_theme/theme/pydata_sphinx_theme/components/navbar-nav.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,5 @@
{# Displays links to the top-level TOCtree elements, in the header navbar. #}
<nav class="navbar-nav">
<p class="sidebar-header-items__title"
role="heading"
aria-level="1"
aria-label="{{ _('Site Navigation') }}">
{{ _("Site Navigation") }}
</p>
<ul class="bd-navbar-elements navbar-nav">
{{ generate_header_nav_html(n_links_before_dropdown=theme_header_links_before_dropdown, dropdown_text=theme_header_dropdown_text) }}
</ul>
Expand Down
1 change: 0 additions & 1 deletion tests/test_build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -964,7 +964,6 @@ def test_translations(sphinx_build_factory) -> None:
index = sphinx_build.html_tree("section1/index.html")

sidebar_primary = index.select(".bd-sidebar-primary")[0]
assert "Navigation du site" in str(sidebar_primary)
assert "Navigation de la section" in str(sidebar_primary)

sidebar_secondary = index.select(".bd-sidebar-secondary")[0]
Expand Down
3 changes: 0 additions & 3 deletions tests/test_build/navbar_ix.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
<div class="me-auto navbar-header-items__center">
<div class="navbar-item">
<nav class="navbar-nav">
<p aria-label="Site Navigation" aria-level="1" class="sidebar-header-items__title" role="heading">
Site Navigation
</p>
<ul class="bd-navbar-elements navbar-nav">
<li class="nav-item">
<a class="nav-link nav-internal" href="page1.html">
Expand Down
3 changes: 0 additions & 3 deletions tests/test_build/sidebar_subpage.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,6 @@
<div class="sidebar-header-items__center">
<div class="navbar-item">
<nav class="navbar-nav">
<p aria-label="Site Navigation" aria-level="1" class="sidebar-header-items__title" role="heading">
Site Navigation
</p>
<ul class="bd-navbar-elements navbar-nav">
<li class="nav-item">
<a class="nav-link nav-internal" href="../page1.html">
Expand Down
Loading