-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add anonymous crossoriginto fontawesome fonts #1634
Conversation
To test a build against a branch you need to install the lib using the git reference. Somwhere in your replace this line with the PR url as such: and you will be using this exact branch instead of the one published on pypi |
(Sorry for the delay.) In fact don't have any
It looks it was properly installed but I couldn't find any
in |
BTW, during the first |
all the warnings you get are unrelated to the theme and due to issues with autosummary and I guess, API generation. let's focus on the subject at hand for the moment. |
it's perfectly fine as well
That's normal the file is not distributed in the wheel it's simply used to dynamically build static resources upon installation. If you inspect one of these links in the header of the generated header, does it have the |
The 3 links involved have |
ok great so my change is propagated to the version you install bu still don't fix your issue.... |
This was already fixed in another PR so will close this one. Thanks for your work @12rambau 🙏🏽 |
Fix #1613
@dbitouze I'm in unknown territory here so you should consider this PR experimental.
I think the issue is relater to the definition of the links so I tried setting up more details in the webpack.config.js
Could you try your build against this PR version and let us know ?