remove deprecated configs and associated code/tests #1698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drammock
added
the
kind: maintenance
drammock
commented
Feb 1, 2024
| @@ -188,9 +188,7 @@ | |||
| "json_url": json_url, | |||
| "version_match": version_match, | |||
| }, | |||
| "navigation_with_keys": False, | |||
There was a problem hiding this comment.
False is now the default in theme.conf so we don't need to specify it in our own docs (or in any tests) just to avoid the deprecation warning
| # "back_to_top_button": False, | ||
| # "search_bar_position": "navbar", # TODO: Deprecated - remove in future version |
There was a problem hiding this comment.
AFAICT this config was being silently ignored, and associated code was already removed
12rambau
reviewed
Feb 5, 2024
| @@ -25,41 +25,6 @@ def update_config(app): | |||
| theme_options = utils.get_theme_options_dict(app) | |||
| warning = partial(utils.maybe_warn, app) | |||
|
|
|||
| # TODO: deprecation; remove after 0.14 release | |||
There was a problem hiding this comment.
Can you confirm this was already removed long ago ? I didn't find it in theme.conf
There was a problem hiding this comment.
- marked as "deprecate after 0.11" (2022 Jun): https://github.com/pydata/pydata-sphinx-theme/pull/698/files#diff-f0f04e8b873a8565b32c276f0dfcfbdb49b0f8b1c022d8cb59cd179872f542dfR42-R43
- Removed from
theme.conf(2023 Feb): 9a10f9d#diff-f0f04e8b873a8565b32c276f0dfcfbdb49b0f8b1c022d8cb59cd179872f542dfL52-L53
12rambau
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.