BUG - Ensure lists markers colours are visible #1711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trallard
added
kind: bug
|
@trallard I pushed here to get the CIs to run (lint was failing). FYI, seems like maybe your pre-commit hooks aren't set up correctly (or maybe you did this on a new/borrowed computer or something?). |
|
Thank you! I used codespaces for this PR as it was a quick one so will make sure to remember this the next time. |
Should we consider https://pre-commit.ci/ to streamline cases like this? I can't recall if we already discussed/rejected that idea here, or if that was a different repo. |
|
+1 on pre-commit.ci |
|
looks good!
|
drammock
approved these changes
Feb 12, 2024
ivanov
pushed a commit
to ivanov/pydata-sphinx-theme
that referenced
this pull request
Jun 5, 2024
* Set table colour to match text * fix lint --------- Co-authored-by: Daniel McCloy <dan@mccloy.info>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1710
Sets the table colour to
--pst-color-text-baseinstead of the default Bootstrap colour