Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make codecov work better #1741

Merged
merged 3 commits into from
Mar 15, 2024
Merged

make codecov work better #1741

merged 3 commits into from
Mar 15, 2024

Conversation

drammock
Copy link
Collaborator

source of this idea is a codecov employee:

codecov/codecov-action#1274 (comment)

@drammock drammock added kind: maintenance Improving maintainability and reducing technical debt tag: CI Pull requests that update GitHub Actions code labels Mar 14, 2024
Copy link
Collaborator

@gabalafou gabalafou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure at first if passing the secret via env would be a potential security issue, but the GitHub Actions docs state:

To make a secret available to an action, you must set the secret as an input or environment variable in the workflow file.
-https://docs.github.com/en/actions/security-guides/using-secrets-in-github-actions#accessing-your-secrets

So that seems legit to me and all of the checks pass on this PR, so I'm approving it.

@drammock
Copy link
Collaborator Author

OK, well the verbose helped, at least: we have useful information in the log now!

info - 2024-03-14 14:58:12,067 -- Process Commit creating complete
debug - 2024-03-14 14:58:12,067 -- Commit creating result --- {"result": "RequestResult(error=RequestError(code='HTTP Error 429', params={}, description='{\"detail\":\"Tokenless has reached GitHub rate limit. Please upload using a token: https://docs.codecov.com/docs/adding-the-codecov-token. Expected available in 705 seconds.\"}'), warnings=[], status_code=429, text='{\"detail\":\"Tokenless has reached GitHub rate limit. Please upload using a token: https://docs.codecov.com/docs/adding-the-codecov-token. Expected available in 705 seconds.\"}')"}
error - 2024-03-14 14:58:12,068 -- Commit creating failed: {"detail":"Tokenless has reached GitHub rate limit. Please upload using a token: https://docs.codecov.com/docs/adding-the-codecov-token. Expected available in 705 seconds."}
Error: Codecov: Failed to properly create commit: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1

The token is not getting through somehow.

Co-authored-by: gabalafou <gabriel@fouasnon.com>
.github/workflows/tests.yml Outdated Show resolved Hide resolved
@drammock drammock merged commit 7b463ab into pydata:main Mar 15, 2024
@drammock drammock deleted the codecov-again branch March 15, 2024 21:00
@drammock
Copy link
Collaborator Author

thanks for the teamwork on this one @gabalafou

ivanov pushed a commit to ivanov/pydata-sphinx-theme that referenced this pull request Jun 5, 2024
* see if this fixes codecov

* Update .github/workflows/tests.yml

Co-authored-by: gabalafou <gabriel@fouasnon.com>

* Update .github/workflows/tests.yml [ci skip]

---------

Co-authored-by: gabalafou <gabriel@fouasnon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: maintenance Improving maintainability and reducing technical debt tag: CI Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants