-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make codecov work better #1741
make codecov work better #1741
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't sure at first if passing the secret via env
would be a potential security issue, but the GitHub Actions docs state:
To make a secret available to an action, you must set the secret as an input or environment variable in the workflow file.
-https://docs.github.com/en/actions/security-guides/using-secrets-in-github-actions#accessing-your-secrets
So that seems legit to me and all of the checks pass on this PR, so I'm approving it.
OK, well the
The token is not getting through somehow. |
Co-authored-by: gabalafou <gabriel@fouasnon.com>
thanks for the teamwork on this one @gabalafou |
* see if this fixes codecov * Update .github/workflows/tests.yml Co-authored-by: gabalafou <gabriel@fouasnon.com> * Update .github/workflows/tests.yml [ci skip] --------- Co-authored-by: gabalafou <gabriel@fouasnon.com>
source of this idea is a codecov employee:
codecov/codecov-action#1274 (comment)