Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV - Enable pre-commit ci #1752

Merged
merged 1 commit into from
Apr 2, 2024
Merged

DEV - Enable pre-commit ci #1752

merged 1 commit into from
Apr 2, 2024

Conversation

trallard
Copy link
Collaborator

@trallard trallard commented Apr 2, 2024

This PR adds the configuration needed for https://pre-commit.ci/

Note

I sent a request to add pre-commit CI, so someone with admin rights will need to approve this

Closes #1718

@trallard trallard added the tag: dependencies Pull requests that update a dependency file label Apr 2, 2024
@drammock
Copy link
Collaborator

drammock commented Apr 2, 2024

I sent a request to add pre-commit CI, so someone with admin rights will need to approve this

@12rambau and I are "outside collaborators", it needs to be a "member" of the pydata org

@choldgraf
Copy link
Collaborator

I just tried "authorizing" the pre-commit app on GitHub but I got this:

CleanShot 2024-04-02 at 09 03 13@2x

So maybe it needs to be one of this group?

https://github.com/orgs/pydata/people?query=role:owner

@choldgraf
Copy link
Collaborator

Could somebody in @pydata/core please enable pre-commit CI in this repository, and/or give the maintainers here the permissions needed to do so?

To do this, go to pre-commit.ci and then follow the same actions as the GIF below (where I'm doing these actions but run into authorization blocks)

CleanShot 2024-04-02 at 09 50 35

@aterrel
Copy link
Member

aterrel commented Apr 2, 2024 via email

@drammock drammock merged commit 1c0c885 into pydata:main Apr 2, 2024
15 of 16 checks passed
@trallard trallard deleted the trallard/add-pre-commit-ci branch April 4, 2024 17:57
ivanov pushed a commit to ivanov/pydata-sphinx-theme that referenced this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag: dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proposal: adopt precommit.ci
4 participants