Refactor navbar generating function #1780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trallard
added
the
tag: component
On top of pydata#1771, should fix pydata#1773 (once fininished) This try to split the function into two parts: one that wrangle the data, one that generate html. The generating the data part should be cacheable, while the other can be made more flexible to be reusable in different part of the theme (typically generating or not dropdowns in the sidebar or navbar).
Carreau
force-pushed
the
link-toc-refactor
branch
from
1418634 to
2990818
Compare
Carreau
force-pushed
the
link-toc-refactor
branch
from
2990818 to
25e1549
Compare
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
Carreau
changed the title
ivanov
pushed a commit
to ivanov/pydata-sphinx-theme
that referenced
this pull request
Jun 5, 2024
Refactor navbar generating function. This should fix pydata#1773 (once fininished) It tries to split the function into two parts: one that wrangle the data, one that generate html. The generating the data part should be cacheable, while the other can be made more flexible to be reusable in different part of the theme (typically generating or not dropdowns in the sidebar or navbar). --------- Co-authored-by: Daniel McCloy <dan@mccloy.info>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #1773
This try to split the function into two parts: one that wrangle the
data, one that generate html.
The generating the data part should be cacheable, while the other can be
made more flexible to be reusable in different part of the theme
(typically generating or not dropdowns in the sidebar or navbar).