Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove backwards-compatible text-decoration-skip rule #1820

Merged
merged 1 commit into from
May 19, 2024

Conversation

gabalafou
Copy link
Collaborator

@gabalafou gabalafou commented May 17, 2024

Fixes #1684.

text-decoration-skip-ink was added in Safari 15.4 (March 2022)

We do not need to keep text-decoration-skip.

text-decoration-skip-ink was added in Safari 15.4 (March 2022)
https://developer.apple.com/documentation/safari-release-notes/safari-15_4-release-notes#CSS

We do not need to keep text-decoration-skip.
@gabalafou gabalafou force-pushed the fix-css-warnings-firefox branch from 1b86082 to 65b8e37 Compare May 17, 2024 10:09
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

@trallard trallard added tag: CSS CSS and SCSS related issues kind: maintenance Improving maintainability and reducing technical debt labels May 19, 2024
@trallard trallard merged commit 9761e1d into pydata:main May 19, 2024
18 checks passed
@gabalafou gabalafou deleted the fix-css-warnings-firefox branch May 20, 2024 07:03
ivanov pushed a commit to ivanov/pydata-sphinx-theme that referenced this pull request Jun 5, 2024
text-decoration-skip-ink was added in Safari 15.4 (March 2022)
https://developer.apple.com/documentation/safari-release-notes/safari-15_4-release-notes#CSS

We do not need to keep text-decoration-skip.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: maintenance Improving maintainability and reducing technical debt tag: CSS CSS and SCSS related issues
Projects
None yet
3 participants