🐛 BUG: fix double border in deprecated box #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wanna add a |
|
hmmm if seems lighthouse is not happy with this styling? Can we increase the contrast more? |
|
I think the lighthouse failure is caused by the thebe issues (at least that was what I found on another PR where it was also failing) |
|
thebe issues? we run thebe in these docs?! |
|
No, but we use jupyter-sphinx to test the embedding, and that pulls it in -> jupyter/jupyter-sphinx#163 |
|
ah gotcha - OK then let's give this a merge :-) thanks for the improvement |
choldgraf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #242