Implement deterministic dask tokenization. #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hameerabbasi
reviewed
Feb 6, 2020
requirements/tests.txt
Outdated
| @@ -1,3 +1,4 @@ | |||
| dask | |||
There was a problem hiding this comment.
dask[array] I believe?
There was a problem hiding this comment.
I don't think we are using anything from dask.array. The only imports are from dask.base.
There was a problem hiding this comment.
Oops, I was completely wrong about that. Indeed, dask[array] is what we needed. Pushed new commit. :-D
Codecov Report
@@ Coverage Diff @@
## master #320 +/- ##
==========================================
+ Coverage 93.96% 93.97% +<.01%
==========================================
Files 19 19
Lines 2319 2322 +3
==========================================
+ Hits 2179 2182 +3
Misses 140 140 |
hameerabbasi
approved these changes
Feb 6, 2020
|
Thanks, @danielballan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #300
Credit to @crusaderky for suggesting this implementation in that issue.
Here, I add a test. I have verified that it fails as expected before the change
in 136bc85 is introduced.