-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Implement broadcast_to
function
#782
Conversation
CodSpeed Performance ReportMerging #782 will degrade performances by 12.39%Comparing Summary
Benchmarks breakdown
|
I'm hesitant about merging this as it contains lots of heuristics to figure out the output format -- not to mention there should be a "broadcast level" that's the equivalent of a "zero stride", or perhaps we can ignore the broadcast indices on the Python side. |
e46cd64
to
ca55bf7
Compare
ca55bf7
to
bc37447
Compare
The heuristics are gone (they're already added by a different PR). What do you mean by a "broadcast level"? |
Something that represents a zero-stride, or an ignored index. |
Can you give an Array API |
Decided that for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @mtsokol!
Force-merged due to the CI hiccup. Thanks, @mtsokol! |
Hi @hameerabbasi,
This PR adds
broadcast_to
Array API function.It it only broadcasts missing dimensions, for
1
-size dimension it can't broadcast as it's a limitation oflinalg.broadcast
in MLIR.