-
-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Update MLIR backend to LLVM 20.dev #787
Conversation
I think the best option is backporting these PRs as they are blockers and real issues. |
I asked about it here: llvm/llvm-project#109135 (comment). But reshaping and adding Dense formats will stay broken until first 20 RC as it happens to be fixed in the current |
In that case we will need to build LLVM in CI (which is quite complicated) and it absolutely needs to be cached. |
CodSpeed Performance ReportMerging #787 will degrade performances by 32.04%Comparing Summary
Benchmarks breakdown
|
b15dd11
to
954996f
Compare
Right, in #799 I added caching with |
Closing in favour of #799. |
Hi @hameerabbasi,
This PR updates MLIR backend to current LLVM 20.dev (so
main
branch) experimentally:format
attribute to Tensor class.tensor.empty
call link.As you can see it fixes a bunch of skips in the test suite: sparse/mlir_backend/tests/test_simple.py
It's thanks to changes already present in
main
branch, added after19.x
branched, and:soa
property tosparse_tensor
Python bindings llvm/llvm-project#109135encoding
argument totensor.empty
Python function llvm/llvm-project#110656test_output.py
test llvm/llvm-project#110882Maybe one thing that we can consider is to have a
nightly
label for MLIR Python bindings feedstock some time in the future? Otherwise, I guess20.x
will branch in ~6months?