preserve boolean-dtype within encoding, adapt test

pydata · Mar 31, 2023 · 2b63d92 · 2b63d92
1 parent d464bba
commit 2b63d92
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/xarray/coding/variables.py b/xarray/coding/variables.py
@@ -422,7 +422,8 @@ def encode(self, variable: Variable, name: T_Name = None) -> Variable:
     def decode(self, variable: Variable, name: T_Name = None) -> Variable:
         if variable.attrs.get("dtype", False) == "bool":
             dims, data, attrs, encoding = unpack_for_decoding(variable)
-            del attrs["dtype"]
+            # overwrite encoding accordingly and remove from attrs
+            encoding["dtype"] = attrs.pop("dtype")
             data = BoolTypeArray(data)
             return Variable(dims, data, attrs, encoding, fastpath=True)
         else:

diff --git a/xarray/tests/test_backends.py b/xarray/tests/test_backends.py
@@ -630,6 +630,9 @@ def test_roundtrip_boolean_dtype(self) -> None:
         with self.roundtrip(original) as actual:
             assert_identical(original, actual)
             assert actual["x"].dtype == "bool"
+            with self.roundtrip(actual) as actual2:
+                assert_identical(original, actual2)
+                assert actual2["x"].dtype == "bool"
 
     def test_orthogonal_indexing(self) -> None:
         in_memory = create_test_data()