Fix datetime.timedelta casting bug in coding.times.infer_datetime_units #2128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoyer
reviewed
May 14, 2018
xarray/coding/times.py
Outdated
| if unique_timedeltas.dtype == np.dtype('O'): | ||
| # Convert to np.timedelta64 objects using pandas to work around a | ||
| # NumPy casting bug: https://github.com/numpy/numpy/issues/11096 | ||
| unique_timedeltas = pd.to_timedelta(unique_timedeltas).values |
There was a problem hiding this comment.
use pd.to_timedelta(unique_timedeltas, box=False) instead of pd.to_timedelta(unique_timedeltas).values.
ocefpaf
reviewed
May 14, 2018
| @@ -21,4 +20,4 @@ dependencies: | |||
| - rasterio | |||
| - zarr | |||
| - pip: | |||
| - cftime | |||
| - netcdf4 | |||
There was a problem hiding this comment.
Latest conda-forge netcdf4 does use cftime.
There was a problem hiding this comment.
Thanks @ocefpaf -- we need to use pip in this case only since we use this environment to test on the win-32 platform: conda-forge/cftime-feedstock#2.
|
Thanks @shoyer, it looks like things are green now. Let me know if you have any more comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can confirm the docs now build properly locally: