Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default flag for open_mfdataset. Fixes Issue #2064 #3120

Closed

Conversation

bonnland
Copy link

@bonnland bonnland commented Jul 13, 2019

I'm not sure I should add a test, because it's just changing the default behavior, and it requires a dataset file to be added.

I'm not sure it needs additional documentation, because Sphinx should update the default flag. Should what-new.rst be updated?

@codecov
Copy link

codecov bot commented Jul 13, 2019

Codecov Report

Merging #3120 into master will decrease coverage by 0.27%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3120      +/-   ##
==========================================
- Coverage      96%   95.72%   -0.28%     
==========================================
  Files          63       63              
  Lines       12777    12777              
==========================================
- Hits        12266    12231      -35     
- Misses        511      546      +35

@bonnland
Copy link
Author

I'm seeing that five unit tests are failing on some of the builds. I'm looking into addressing the failing tests now.

@jhamman
Copy link
Member

jhamman commented Sep 14, 2023

Closing this as stale. Thanks @bonnland for the contribution. Feel free to reopen if there is interest in picking this up again.

@jhamman jhamman closed this Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

concat_dim getting added to *all* variables of multifile datasets
2 participants