-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove future statements #3194
Remove future statements #3194
Conversation
In all seriousness, pyupgrade will do this and more automatically with the --py3-only option. I'd add it to CI! |
We did run it through! #3190 But not with the One reason not to enforce it - I can't seem to work out how to apply it to all files in a repo - am I missing something basic? Or does it need another process to loop over files? |
The author pushes pre-commit pretty hard, but that shouldn't be a problem for Xarray as we're already using it. Then |
I think We could add this to If anyone is up for a side project - a tool that submits PRs whenever someone commits non-idiomatic code! Open minded as ever though |
One addendum: if |
My config uses [testenv:check]
deps =
-r requirements.txt
whitelist_externals = bash
commands =
autoflake --recursive --in-place --remove-all-unused-imports --remove-duplicate-keys --remove-unused-variables .
bash -c \"pyupgrade --py36-plus **.py\"
isort --recursive --apply .
black .
flake8
mypy --config-file=tox.ini . src/
bandit --recursive --exclude=./.tox/** --skip=B101,B110,B310 --quiet . |
Nice! That's quite a list. Between us there's an xkcd or narkoz reference... |
* upstream/master: Ignore example.grib.0112.idx file (pydata#3198) small updates to the contributing.rst (it could use more) (pydata#3193) Remove future statements (pydata#3194) update instructions (pydata#3195)
Not sure why these weren't picked up in some of the previous python3-ifying