One-off isort run #3196
Merged
One-off isort run #3196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for review and merge |
|
I was thinking about doing this (and had done it a couple of times in the past). My only concern with doing it now is whether it's likely to exacerbate any merge conflicts from the black changes. I've found that merge conflicts scale super-linearly with changes, at least in frustration if not lines - if so potentially we could wait for the outstanding PRs to update and then rerun? |
|
Fine for me - is a week enough to allow everybody to adapt? |
|
Updated, re-run everything, and removed the blanket F401 (unused import) suppression. |
|
Great, +1 from me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A one-off, manually vetted and tweaked isort run