Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow weakref #3318

Merged
merged 4 commits into from
Sep 18, 2019
Merged

Allow weakref #3318

merged 4 commits into from
Sep 18, 2019

Conversation

crusaderky
Copy link
Contributor

@crusaderky crusaderky commented Sep 18, 2019 •
edited
Loading

@crusaderky
Copy link
Contributor Author

Ready for review and merge

max-sixty
max-sixty approved these changes Sep 18, 2019
View reviewed changes
Copy link
Collaborator

@max-sixty max-sixty left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, that's lightning fast

doc/whats-new.rst Outdated Show resolved Hide resolved
@crusaderky @max-sixty
Update doc/whats-new.rst
cda02a5 
Co-Authored-By: Maximilian Roos <5635139+max-sixty@users.noreply.github.com>
@crusaderky crusaderky merged commit fddced0 into pydata:master Sep 18, 2019
@crusaderky crusaderky deleted the weakref branch September 18, 2019 15:53
dcherian added a commit to dcherian/xarray that referenced this pull request Sep 19, 2019
@dcherian
Merge remote-tracking branch 'upstream/master' into map_blocks_2
180bbf2 
* upstream/master:
  Fix isel performance regression (pydata#3319)
  Allow weakref (pydata#3318)
  Clarify that "scatter" is a plotting method in what's new. (pydata#3316)
dcherian added a commit that referenced this pull request Sep 24, 2019
@dcherian
Merge remote-tracking branch 'upstream/master' into scipy19-docs
aeb15b5 
* upstream/master: (43 commits)
  Add hypothesis support to related projects (#3335)
  More doc fixes (#3333)
  Improve the documentation of swap_dims (#3331)
  fix the doc names of the return value of swap_dims (#3329)
  Fix isel performance regression (#3319)
  Allow weakref (#3318)
  Clarify that "scatter" is a plotting method in what's new. (#3316)
  Fix whats-new date :/
  Revert to dev version
  Release v0.13.0
  auto_combine deprecation to 0.14 (#3314)
  Deprecation: groupby, resample default dim. (#3313)
  Raise error if cmap is list of colors (#3310)
  Refactor concat to use merge for non-concatenated variables (#3239)
  Honor `keep_attrs` in DataArray.quantile (#3305)
  Fix DataArray api doc (#3309)
  Accept int value in head, thin and tail (#3298)
  ignore h5py 2.10.0 warnings and fix invalid_netcdf warning test. (#3301)
  Update why-xarray.rst with clearer expression (#3307)
  Compat and encoding deprecation to 0.14 (#3294)
  ...
@djhoese
Copy link
Contributor

djhoese commented Oct 3, 2019

Any idea when a 0.13.1 release might be made to get this fix out in the wild?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-sixty max-sixty max-sixty approved these changes

@shoyer shoyer Awaiting requested review from shoyer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't create weakrefs on DataArrays since xarray 0.13.0
3 participants
@crusaderky @djhoese @max-sixty