Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix html repr on non-str keys #3870

Merged
merged 3 commits into from
Mar 20, 2020
Merged

Fix html repr on non-str keys #3870

merged 3 commits into from
Mar 20, 2020

Conversation

max-sixty
Copy link
Collaborator

@max-sixty
Copy link
Collaborator Author

Docs failing, I think on:

/usr/share/miniconda/envs/xarray-tests/lib/python3.8/site-packages/sphinx_rtd_theme/search.html:21: RemovedInSphinx30Warning: To modify script_files in the theme is deprecated. Please insert a <script> tag directly in your theme instead.

Anyone have any ideas?

@mathause mathause mentioned this pull request Mar 20, 2020
Closed
13 tasks
@keewis
Copy link
Collaborator

keewis commented Mar 20, 2020

This warning is something we can't do anything about; we have to wait for a release of sphinx_rtd_theme (it is fixed on their master).

It does not cause sphinx to fail, though. In general, if the docs are failing it's mostly due to some error / warning elevated to error in the "reading" step, in this case:

/home/vsts/work/1/s/doc/whats-new.rst:91: WARNING: Inline literal start-string without end-string.

which should be easy to fix (I assume using "Datasets" without a space after the backtick is forbidden?).

keewis
keewis reviewed Mar 20, 2020
View reviewed changes
doc/whats-new.rst Outdated Show resolved Hide resolved
@dcherian @keewis
Update doc/whats-new.rst
f09f722 
Co-Authored-By: keewis <keewis@users.noreply.github.com>
@max-sixty
Copy link
Collaborator Author

Thanks @keewis !

@max-sixty max-sixty merged commit 564a291 into pydata:master Mar 20, 2020
@max-sixty max-sixty deleted the html-non-str branch March 20, 2020 17:04
dcherian added a commit to dcherian/xarray that referenced this pull request Mar 22, 2020
@dcherian
Merge remote-tracking branch 'upstream/master' into indexvariable-values
8f464c4 
* upstream/master:
  add spacing in the versions section of the issue report (pydata#3876)
  map_blocks: allow user function to add new unindexed dimension. (pydata#3817)
  Delete associated indexes when deleting coordinate variables. (pydata#3840)
  remove macos build while waiting for libwebp fix (pydata#3875)
  Fix html repr on non-str keys (pydata#3870)
  Allow ellipsis to be used in stack (pydata#3826)
  Improve where docstring (pydata#3836)
  Add DataArray.pad, Dataset.pad, Variable.pad (pydata#3596)
  Fix some warnings (pydata#3864)
  Feature/weighted (pydata#2922)
  Fix recombination in groupby when changing size along the grouped dimension (pydata#3807)
  Blacken the doctest code in docstrings (pydata#3857)
  Fix multi-index with categorical values. (pydata#3860)
  Fix interp bug when indexer shares coordinates with array (pydata#3758)
  Fix alignment with join="override" when some dims are unindexed (pydata#3839)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcherian dcherian dcherian approved these changes

@keewis keewis keewis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@max-sixty @keewis @dcherian