rm inplace arg to rename

[raybellwaves]

This PR follows a TypeError I got

ds = xr.open_dataset('https://thredds.ucar.edu/thredds/dodsC/grib/NCEP/GFS/Global_0p25deg/Best')
ds.rename({'lat': 'latitude', 'lon': 'longitude'}, inplace=True)
TypeError: The `inplace` argument has been removed from xarray. You can achieve an identical effect with python's standard assignment.

I saw the option of the inplace in the docs
http://xarray.pydata.org/en/stable/generated/xarray.Dataset.rename.html

Removing this argument.

TODO:

• rm test_rename_inplace

[pep8speaks]

Hello @raybellwaves! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-11-04 21:27:35 UTC

[max-sixty]

Thanks @raybellwaves !

[max-sixty]

The reason this was here is so people get a useful error as they make the transition.

It's probably been there long enough that we can remove it (no strong view though)

[max-sixty]

One alternative is to remove inplace from the signature, and instead extract it from kwargs. As above, I would be fine removing it, though.

[mathause]

This was in 0.13 http://xarray.pydata.org/en/stable/whats-new.html#v0-13-0-17-sep-2019 I actually don't know if we have an official policy for deprecations? Two major versions?

Should all of these checks be removed? #3260

[max-sixty]

I don't think we have a strict policy but a few releases seem fine. Eventually they should go all go; but fine to merge them as we go too.

[max-sixty]

Great, merging! Thanks @raybellwaves !

[max-sixty]

Erm, actually I think you may have to take it off WIP first