Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unpin pip 20.2 again #4656

Merged
merged 7 commits into from
Apr 18, 2021
Merged

unpin pip 20.2 again #4656

merged 7 commits into from
Apr 18, 2021

Conversation

mathause
Copy link
Collaborator

@mathause mathause commented Dec 6, 2020

Another enormous PR from my side ;) unpin pip again. numpy probably fixed the issue re the name of the nightly build. But I also need to doublecheck if scipy is ok.

@keewis
Copy link
Collaborator

keewis commented Dec 6, 2020

thanks for keeping an eye on this, @mathause. Unfortunately, scipy doesn't seem to have fixed their package, yet, which means that we have to wait with the merge until they do.

@max-sixty
Copy link
Collaborator

Another enormous PR from my side ;)

Highest value per line changed! 😀

@keewis
Copy link
Collaborator

keewis commented Feb 9, 2021

it seems scipy fixed this, but their wheel building repository fails the py38 build jobs so there's no py38 manylinux wheels. We could upgrade the upstream-dev CI to py39, but unfortunately there's no stable release of numba with py39 support.

Edit: see scipy/scipy#13540 and MacPython/scipy-wheels#114

@keewis
Copy link
Collaborator

keewis commented Apr 10, 2021

we upgraded upstream-dev to py39 so we should be able install scipy with the new dependency resolver again, but they currently have trouble with their wheel building repository so the wheels we install are from early March. No reason not to merge this PR, though.

Edit: never mind, it seems scipy still has version inconsistencies, even with the wheels from early March (the filename still contains the date while the metadata doesn't)

@keewis keewis closed this Apr 18, 2021
@keewis keewis reopened this Apr 18, 2021
@keewis
Copy link
Collaborator

keewis commented Apr 18, 2021

it seems scipy has fixed their packages. If CI passes we should be able to finally merge this.

Edit: CI says

Successfully installed numpy-1.21.0.dev0+1312.gcffb69356 pandas-1.3.0.dev0+1351.g04f9a4b10d scipy-1.7.0.dev0+810.cfb3e80

So I guess this can be merged?

@keewis
Copy link
Collaborator

keewis commented Apr 18, 2021

the upstream-dev failures are the ones reported by #5077, so this is ready.

@keewis keewis marked this pull request as ready for review April 18, 2021 21:42
@keewis keewis merged commit 90014d4 into pydata:master Apr 18, 2021
@max-sixty
Copy link
Collaborator

Nice! Thanks @keewis !

@mathause mathause deleted the unpin_pip branch October 18, 2021 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants