Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FacetGrid docstrings #5293

Merged
merged 7 commits into from
May 13, 2021
Merged

FacetGrid docstrings #5293

merged 7 commits into from
May 13, 2021
+29 −26

Conversation

zmoon
Copy link
Contributor

@zmoon zmoon commented May 12, 2021

  • Passes pre-commit run --all-files
  • User visible changes (including notable bug fixes) are documented in whats-new.rst

Summary:

@max-sixty max-sixty requested a review from keewis May 12, 2021 16:11
@max-sixty
Copy link
Collaborator

Thanks @zmoon ! I'm going to politely ask @keewis to review this since he has driven many of our improvements in this area.

keewis
keewis approved these changes May 12, 2021
View reviewed changes
Copy link
Collaborator

@keewis keewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot, @zmoon. I only have one minor suggestion.

xarray/plot/facetgrid.py Outdated Show resolved Hide resolved
zmoon and others added 2 commits May 12, 2021 20:25
@zmoon @keewis
Use :py:func: instead of :func:
68b2407 
Co-authored-by: keewis <keewis@users.noreply.github.com>
@zmoon
Add periods; use :py:func: for other subplots
067065c 
[skip-ci]
@dcherian
Copy link
Contributor

Thanks @zmoon. This will really help our users.

@dcherian dcherian merged commit 4067c01 into pydata:master May 13, 2021
@zmoon
Copy link
Contributor Author

zmoon commented May 13, 2021

@dcherian in some sense this is a "user visible change", but quite minor. I wasn't sure if I should have added to What's New or not.

dcherian added a commit to TomNicholas/xarray that referenced this pull request May 13, 2021
@dcherian
Merge remote-tracking branch 'upstream/master' into update_release_guide
a9cbf80 
* upstream/master:
  combine keep_attrs and combine_attrs in apply_ufunc (pydata#5041)
  Explained what a deprecation cycle is (pydata#5289)
  Code cleanup (pydata#5234)
  FacetGrid docstrings (pydata#5293)
  Add whats new for dataset interpolation with non-numerics (pydata#5297)
  Allow dataset interpolation with different datatypes (pydata#5008)
  Flexible indexes: add Index base class and xindexes properties (pydata#5102)
  pre-commit: autoupdate hook versions (pydata#5280)
  convert the examples for apply_ufunc to doctest (pydata#5279)
  fix the new whatsnew section
  Ensure `HighLevelGraph` layers are `Layer` instances (pydata#5271)
dcherian added a commit to matzegoebel/xarray that referenced this pull request May 13, 2021
@dcherian
Merge remote-tracking branch 'upstream/master' into dev
74568b6 
* upstream/master: (23 commits)
  combine keep_attrs and combine_attrs in apply_ufunc (pydata#5041)
  Explained what a deprecation cycle is (pydata#5289)
  Code cleanup (pydata#5234)
  FacetGrid docstrings (pydata#5293)
  Add whats new for dataset interpolation with non-numerics (pydata#5297)
  Allow dataset interpolation with different datatypes (pydata#5008)
  Flexible indexes: add Index base class and xindexes properties (pydata#5102)
  pre-commit: autoupdate hook versions (pydata#5280)
  convert the examples for apply_ufunc to doctest (pydata#5279)
  fix the new whatsnew section
  Ensure `HighLevelGraph` layers are `Layer` instances (pydata#5271)
  New whatsnew section
  Release-workflow: Bug fix (pydata#5273)
  more maintenance on whats-new.rst (pydata#5272)
  v0.18.0 release highlights (pydata#5266)
  Fix exception when display_expand_data=False for file-backed array. (pydata#5235)
  Warn ignored keep attrs (pydata#5265)
  Disable workflows on forks (pydata#5267)
  fix the built wheel test (pydata#5270)
  pypi upload workflow maintenance (pydata#5269)
  ...
dcherian added a commit to gcaria/xarray that referenced this pull request May 13, 2021
@dcherian
Merge remote-tracking branch 'upstream/master' into error_message_tim…
c33fa82 
…e_units

* upstream/master:
  combine keep_attrs and combine_attrs in apply_ufunc (pydata#5041)
  Explained what a deprecation cycle is (pydata#5289)
  Code cleanup (pydata#5234)
  FacetGrid docstrings (pydata#5293)
  Add whats new for dataset interpolation with non-numerics (pydata#5297)
  Allow dataset interpolation with different datatypes (pydata#5008)
  Flexible indexes: add Index base class and xindexes properties (pydata#5102)
dcherian added a commit to ahuang11/xarray that referenced this pull request May 13, 2021
@dcherian
Merge remote-tracking branch 'upstream/master' into drop_duplicates_dim
2e8dbd3 
* upstream/master:
  Update release guide (pydata#5274)
  combine keep_attrs and combine_attrs in apply_ufunc (pydata#5041)
  Explained what a deprecation cycle is (pydata#5289)
  Code cleanup (pydata#5234)
  FacetGrid docstrings (pydata#5293)
  Add whats new for dataset interpolation with non-numerics (pydata#5297)
  Allow dataset interpolation with different datatypes (pydata#5008)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keewis keewis keewis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zmoon @max-sixty @dcherian @keewis