Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gen_cluster failures; dask_version tweaks #5610

Merged
merged 4 commits into from
Jul 15, 2021

Conversation

crusaderky
Copy link
Contributor

@crusaderky crusaderky commented Jul 15, 2021

  • fixes one of the issues reported in ⚠️ Nightly upstream-dev CI failed ⚠️ #5600
  • distributed.utils_test.gen_cluster no longer accepts timeout=None for the sake of robustness
  • deleted ancient dask backwards compatibility code
  • clean up code around dask.__version__

@pep8speaks
Copy link

pep8speaks commented Jul 15, 2021

Hello @crusaderky! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-07-15 16:43:47 UTC

@crusaderky crusaderky requested a review from keewis July 15, 2021 16:31
@github-actions
Copy link
Contributor

github-actions bot commented Jul 15, 2021

Unit Test Results

         6 files  ±0           6 suites  ±0   54m 25s ⏱️ ±0s
16 171 tests ±0  14 440 ✔️ ±0  1 730 💤 ±0  1 ❌ ±0 
90 222 runs  ±0  82 071 ✔️ ±0  8 145 💤 ±0  6 ❌ ±0 

For more details on these failures, see this check.

Results for commit bc92331. ± Comparison against base commit bc92331.

♻️ This comment has been updated with latest results.

@dcherian
Copy link
Contributor

dcherian commented Jul 15, 2021

You'll need a commit with [test-upstream] in the message to run the upstream-dev CI

@crusaderky crusaderky closed this Jul 15, 2021
@crusaderky crusaderky reopened this Jul 15, 2021
Copy link
Collaborator

@keewis keewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick fix and the clean-up, @crusaderky.

In case of temporary errors (such as the mamba connection errors that sometimes appear) there is a "Rerun all jobs" button to rerun the workflow (it needs to either be cancelled or completed first, though). Closing and reopening works, too, but it reruns everything (including RTD) and the list of checks is extended.

@keewis
Copy link
Collaborator

keewis commented Jul 15, 2021

the remaining error is the other one reported in #5600 so this should be ready to merge. Unless you want to add a "internals" whats-new.rst entry?

@crusaderky crusaderky merged commit bc92331 into pydata:main Jul 15, 2021
@crusaderky crusaderky deleted the gen_cluster branch July 15, 2021 17:25
@crusaderky
Copy link
Contributor Author

crusaderky commented Jul 15, 2021

Unless you want to add a "internals" whats-new.rst entry?

I think it may be a bit overkill?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants