Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accommodate OutOfBoundsTimedelta error when decoding times #6717

Merged
merged 2 commits into from
Jun 24, 2022

Conversation

spencerkclark
Copy link
Member

@spencerkclark spencerkclark commented Jun 23, 2022

The development version of pandas raises an OutOfBoundsTimedelta error instead of an OverflowError in pd.to_timedelta if the timedelta cannot be represented with nanosecond precision. Therefore we must also be ready to catch that when decoding times.

The OutOfBoundsTimedelta exception was added in pandas version 1.1, which is prior to our current minimum version (1.2), so it should be safe to import without a version check.

  • User visible changes (including notable bug fixes) are documented in whats-new.rst

@dcherian
Copy link
Contributor

Thanks @spencerkclark ! All cftime failures look to be fixed.

@andersy005 andersy005 added the plan to merge Final call for comments label Jun 23, 2022
@dcherian dcherian merged commit 6c8db5e into pydata:main Jun 24, 2022
@spencerkclark spencerkclark deleted the OutOfBoundsTimedelta branch June 24, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plan to merge Final call for comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants