Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary build dependencies, use build defaults, strict twine check #6979

Merged
merged 1 commit into from
Sep 10, 2022

Conversation

mwtoews
Copy link
Contributor

@mwtoews mwtoews commented Sep 1, 2022

This PR does a few related things:

  • Remove wheel from pyproject.toml, since it is no longer needed/documented (e.g. here), and rename other dependencies to their names in PyPI
  • Remove pip install build dependencies already specified in pyproject.toml
  • Remove check-manifest, since it isn't used
  • The command python -m build has defaults to build both sdist and wheel outputs
  • Use twine check --strict to return non-zero status on warnings

@github-actions github-actions bot added the Automation Github bots, testing workflows, release automation label Sep 1, 2022
@andersy005
Copy link
Member

andersy005 commented Sep 9, 2022

Remove check-manifest, since it isn't used

Could we keep check-manifest and add a proper check instead of removing it entirely? It's worth ensuring we are shipping everything and check-manifest would help catch missing files, etc...

@mwtoews
Copy link
Contributor Author

mwtoews commented Sep 10, 2022

Could we keep check-manifest and add a proper check instead of removing it entirely? It's worth ensuring we are shipping everything and check-manifest would help catch missing files, etc...

My guess is that it hasn't been needed since #4519 when MANIFEST.in was cleaned up by @max-sixty. It hasn't been needed since #3714. Also, from the check-manifest docs here:

Note that setuptools_scm usually makes MANIFEST.in files obsolete. Having one is helpful only if you intend to build an sdist and then use that sdist to perform further builds, instead of building from a source checkout.

Is this relevant? From my laptop, check-manifest takes ~10 seconds to compute. What value does it bring to CI checking?

@andersy005
Copy link
Member

thank you for the clarification, @mwtoews

Copy link
Member

@andersy005 andersy005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks solid to me 🎉!! thank you for this addition, @mwtoews

@max-sixty max-sixty merged commit c0011e1 into pydata:main Sep 10, 2022
@mwtoews mwtoews deleted the python-build branch September 10, 2022 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Automation Github bots, testing workflows, release automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants