-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary build dependencies, use build defaults, strict twine check #6979
Conversation
Could we keep |
My guess is that it hasn't been needed since #4519 when MANIFEST.in was cleaned up by @max-sixty. It hasn't been needed since #3714. Also, from the check-manifest docs here:
Is this relevant? From my laptop, check-manifest takes ~10 seconds to compute. What value does it bring to CI checking? |
thank you for the clarification, @mwtoews |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks solid to me 🎉!! thank you for this addition, @mwtoews
This PR does a few related things:
wheel
frompyproject.toml
, since it is no longer needed/documented (e.g. here), and rename other dependencies to their names in PyPIpip install
build dependencies already specified inpyproject.toml
check-manifest
, since it isn't usedpython -m build
has defaults to build both sdist and wheel outputstwine check --strict
to return non-zero status on warnings