Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support the new compression argument in netCDF4 > 1.6.0 #6981

Merged
merged 12 commits into from
Dec 1, 2022
Merged

Support the new compression argument in netCDF4 > 1.6.0 #6981

merged 12 commits into from
Dec 1, 2022

Conversation

markelg
Copy link
Contributor

@markelg markelg commented Sep 2, 2022 •
edited
Loading

@markelg
Copy link
Contributor Author

markelg commented Sep 8, 2022

I think this is ready, unfortunately it does not make sense to merge it yet, and one test is failing, because netcdf-c 4.9.0 is not yet available in conda-forge (see conda-forge/libnetcdf-feedstock#140). So I would put it on hold.

@headtr1ck
Copy link
Collaborator

I think this is ready, unfortunately it does not make sense to merge it yet, and one test is failing, because netcdf-c 4.9.0 is not yet available in conda-forge (see conda-forge/libnetcdf-feedstock#140). So I would put it on hold.

Should exist now.

@dopplershift
Copy link
Contributor

We elected not to start rebuilding things with netCDF 4.9.0 since 4.9.1 should be out realSoonNow™️ , so I don't think there's a netcdf4 package in conda-forge that has it yet.

This was referenced Oct 31, 2022
Closed
Open
@dcherian
Copy link
Contributor

dcherian commented Dec 1, 2022

Thanks @markelg!

@dcherian dcherian changed the title Added support for the new compression argument in netCDF4 > 1.6.0 Support the new compression argument in netCDF4 > 1.6.0 Dec 1, 2022
@dcherian dcherian enabled auto-merge (squash) December 1, 2022 22:22
@dcherian dcherian merged commit 92e7cb5 into pydata:main Dec 1, 2022
dcherian added a commit to dcherian/xarray that referenced this pull request Dec 2, 2022
@dcherian
Merge remote-tracking branch 'upstream/main' into groupby-save-codes-new
004a674 
* upstream/main: (39 commits)
  Support the new compression argument in netCDF4 > 1.6.0 (pydata#6981)
  Remove setuptools-scm-git-archive, require setuptools-scm>=7 (pydata#7253)
  Fix mypy failures (pydata#7343)
  Docs: add example of writing and reading groups to netcdf (pydata#7338)
  Reset file pointer to 0 when reading file stream (pydata#7304)
  Enable mypy warn unused ignores (pydata#7335)
  Optimize some copying (pydata#7209)
  Add parse_dims func (pydata#7051)
  Fix coordinate attr handling in `xr.where(..., keep_attrs=True)` (pydata#7229)
  Remove code used to support h5py<2.10.0 (pydata#7334)
  [pre-commit.ci] pre-commit autoupdate (pydata#7330)
  Fix PR number in what’s new (pydata#7331)
  Enable `origin` and `offset` arguments in `resample` (pydata#7284)
  fix doctests: supress urllib3 warning (pydata#7326)
  fix flake8 config (pydata#7321)
  implement Zarr v3 spec support (pydata#6475)
  Fix polyval overloads (pydata#7315)
  deprecate pynio backend (pydata#7301)
  mypy - Remove some ignored packages and modules (pydata#7319)
  Switch to T_DataArray in .coords (pydata#7285)
  ...
@markelg
Copy link
Contributor Author

markelg commented Oct 30, 2023

Sorry for the delay, I completed all the remaining tasks. I hope is ready now. There are some error in the tests but look unrelated to this. There seems to be an assert equal failing because of a nan and nan !=nan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcherian dcherian dcherian left review comments

Assignees
No one assigned
Labels
enhancement io topic-backends upstream issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support new netcdf4 1.6.0 compression arguments
4 participants
@markelg @headtr1ck @dopplershift @dcherian