Code

cf-coding#7654

Code

Closed

kmuehlbauer wants to merge 22 commits intopydata:mainpydata/xarray:mainfrom kmuehlbauer:preserve-bool-dtypekmuehlbauer/xarray:preserve-bool-dtypeCopy head branch name to clipboard

+483-222

Commits

Commits on Apr 4, 2023

• implement coders, adapt tests

  kmuehlbauer

  committed
  d19d57a

• preserve boolean-dtype within encoding, adapt test

  kmuehlbauer

  committed
  2e750e4

• determine cf packed data dtype, adapt tests

  kmuehlbauer

  committed
  0cd301b

• [pre-commit.ci] auto fixes from pre-commit.com hooks

  Show description for 7cfc6ac
  

  pre-commit-ci[bot]

  authored and

  kmuehlbauer

  committed
  7cfc6ac

• fix typing, fix if-clauses, add link to issue

  kmuehlbauer

  committed
  bf4371d

• add comment ass per review

  kmuehlbauer

  committed
  fe006df

• choose float64 if add_offset is not up to cf expectations

  kmuehlbauer

  committed
  66628fc

• use scale_factor/add_offset in tests as specified by cf conventions

  kmuehlbauer

  committed
  b6310e4

• add test which checks add_offset being not conforming to cf standards

  kmuehlbauer

  committed
  06ec16a

• [pre-commit.ci] auto fixes from pre-commit.com hooks

  Show description for 19ef234
  

  pre-commit-ci[bot]

  authored and

  kmuehlbauer

  committed
  19ef234

• convert to float32 to keep pydata#1840 in sync

  kmuehlbauer

  committed
  e877aa7

• [pre-commit.ci] auto fixes from pre-commit.com hooks

  Show description for 8cc7319
  

  pre-commit-ci[bot]

  authored and

  kmuehlbauer

  committed
  8cc7319

• add more comments, add more typing

  kmuehlbauer

  committed
  6a73653

• [pre-commit.ci] auto fixes from pre-commit.com hooks

  Show description for d6887cd
  

  pre-commit-ci[bot]

  authored and

  kmuehlbauer

  committed
  d6887cd

• add additional test, make _choose_float_dtype more explicit

  kmuehlbauer

  committed
  c8c3f14

• Apply suggestions from code review

  Show description for 2f5709a
  

  kmuehlbauer

  and

  Illviljan

  committed
  2f5709a

• [pre-commit.ci] auto fixes from pre-commit.com hooks

  Show description for f215d01
  

  pre-commit-ci[bot]

  authored and

  kmuehlbauer

  committed
  f215d01

• Apply suggestions from code review

  Show description for c5cd53d
  

  kmuehlbauer

  and

  Illviljan

  committed
  c5cd53d

• Test against None, as 0 (False) is a valid input for add_offset. Check for float32/64 only.

  kmuehlbauer

  committed
  986ffc6

• apply astype in the right order to prevent loss of precision, more fillvalue fixes

  kmuehlbauer

  committed
  51f7515

• add mask/scale roundtrip test for variable cf encoding/decoding

  kmuehlbauer

  committed
  8c074f0

• separate CFMaskCoder test for multiple missing_values/__FillValues conflict, use _FillValue for missing_value if available

  kmuehlbauer

  committed
  031cac5