Implement more Variable Coders #7719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 5, 2023
Closed
Illviljan
approved these changes
Apr 5, 2023
Illviljan
reviewed
Apr 5, 2023
dcherian
reviewed
Apr 6, 2023
There was a problem hiding this comment.
Thanks @kmuehlbauer ! Good stuff!
It's definitely a good idea to split big changes into smaller, easier-to-review pieces, so thank you!
Co-authored-by: Illviljan <14371165+Illviljan@users.noreply.github.com>
for more information, see https://pre-commit.ci
|
Now, this is interesting! It looks like those FillValue issues are following me. What did change that this now materializes here, all of a sudden. Update: Small change - big issue. Checked for |
|
This looks like it is ready to go. This will surely help further refactoring |
|
Thanks @kmuehlbauer |
dcherian
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whats-new.rstThis PR implements remaining functionality in
encode_cf_variable/decode_cf_variableasVariableCoders(as left as todo by @shoyer). It adapts the needed tests and adds some typing (thanks @Illviljan). Otherwise there are no changes in function to code.It splits out of #7654 which turns out to be hard to follow (at least for me).