Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure no forward slashes in names for HDF5-based backends #7953

Merged
merged 7 commits into from
Jul 6, 2023
Merged

ensure no forward slashes in names for HDF5-based backends #7953

merged 7 commits into from
Jul 6, 2023

Conversation

kmuehlbauer
Copy link
Contributor

headtr1ck
headtr1ck approved these changes Jun 30, 2023
View reviewed changes
Copy link
Collaborator

@headtr1ck headtr1ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

xarray/backends/netCDF4_.py Show resolved Hide resolved
jhamman
jhamman approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@jhamman jhamman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion but this looks great.

@kmuehlbauer @jhamman
Update xarray/backends/netCDF4_.py
0e91cfe 
Co-authored-by: Joe Hamman <jhamman1@gmail.com>
@kmuehlbauer kmuehlbauer added the plan to merge Final call for comments label Jul 4, 2023
@dcherian dcherian merged commit 17c9e8f into pydata:main Jul 6, 2023
dcherian added a commit to dcherian/xarray that referenced this pull request Jul 16, 2023
@dcherian
Merge branch 'main' into warn-nd-index-var
65c658b 
* main:
  Remove hue_style from plot1d docstring (pydata#7925)
  Add new what's new section (pydata#7986)
  Release summary for v2023.07.0 (pydata#7979)
  Improve explanation in example "Working with Multidimensional Coordinates" (pydata#7984)
  Fix typo in zarr.py (pydata#7983)
  Examples added to docstrings  (pydata#7936)
  [pre-commit.ci] pre-commit autoupdate (pydata#7973)
  Skip broken tests on python 3.11 and windows (pydata#7972)
  Use another repository for upstream testing (pydata#7970)
  Move absolute path finder from open_mfdataset to own function (pydata#7968)
  ensure no forward slashes in names for HDF5-based backends (pydata#7953)
  Chunked array docs (pydata#7951)
  [pre-commit.ci] pre-commit autoupdate (pydata#7959)
  manually unshallow the repository on RTD (pydata#7961)
  Update minimum version of typing extensions in pre-commit (pydata#7960)
  Docstring examples (pydata#7881)
@TomNicholas TomNicholas mentioned this pull request Jul 30, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@headtr1ck headtr1ck headtr1ck approved these changes

@jhamman jhamman jhamman approved these changes

Assignees
No one assigned
Labels
io plan to merge Final call for comments topic-backends
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'/' in variable name causes to_netcdf() to crash
4 participants
@kmuehlbauer @jhamman @headtr1ck @dcherian