Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change type of curvefit's p0 and bounds to mapping #8502

Merged
merged 2 commits into from
Dec 1, 2023
Merged

change type of curvefit's p0 and bounds to mapping #8502

merged 2 commits into from
Dec 1, 2023

Conversation

headtr1ck
Copy link
Collaborator

@headtr1ck headtr1ck commented Dec 1, 2023 •
edited
Loading

  • User visible changes (including notable bug fixes) are documented in whats-new.rst

Mini PR to improve the typing of curvefit.
Using dict is problematic since it is invariant, while Mapping is covariant.

@headtr1ck headtr1ck added plan to merge Final call for comments topic-typing labels Dec 1, 2023
@dcherian dcherian merged commit 5213f0d into pydata:main Dec 1, 2023
31 of 35 checks passed
@headtr1ck headtr1ck deleted the curvefittyping branch December 2, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
plan to merge Final call for comments topic-typing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@headtr1ck @dcherian