Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typing to test_groupby.py #8890

Merged
merged 21 commits into from
Mar 29, 2024
Merged

Conversation

Illviljan
Copy link
Contributor

@Illviljan Illviljan commented Mar 29, 2024

Enforce typing on all tests in test_groupby.py and add the remaining type hints.

@dcherian
Copy link
Contributor

(suggest deleting ci.yaml and then reverting that so only mypy runs)

@Illviljan Illviljan marked this pull request as ready for review March 29, 2024 15:37
xarray/tests/test_groupby.py Show resolved Hide resolved
# regression test for #326
array = self.da
grouped = array.groupby("abc")
actual = grouped.map(np.asarray)
actual = grouped.map(np.asarray) # type: ignore[arg-type] # TODO: Not sure using np.asarray like this makes sense with array api
Copy link
Contributor Author

@Illviljan Illviljan Mar 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think mypy is correct to complain here.

Maybe it's this particular example but xp.asarray is always converted to a xp array according to array api, haven't tried it myself but probably numpy 2.0 as well.

The particular issue: #326, #327

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I bet we need to adapt to the new apis here.

xarray/tests/test_groupby.py Show resolved Hide resolved
@dcherian dcherian merged commit 47ff159 into pydata:main Mar 29, 2024
35 of 37 checks passed
dcherian added a commit to dcherian/xarray that referenced this pull request Apr 2, 2024
* main: (26 commits)
  [pre-commit.ci] pre-commit autoupdate (pydata#8900)
  Bump the actions group with 1 update (pydata#8896)
  New empty whatsnew entry (pydata#8899)
  Update reference to 'Weighted quantile estimators' (pydata#8898)
  2024.03.0: Add whats-new (pydata#8891)
  Add typing to test_groupby.py (pydata#8890)
  Avoid in-place multiplication of a large value to an array with small integer dtype (pydata#8867)
  Check for aligned chunks when writing to existing variables (pydata#8459)
  Add dt.date to plottable types (pydata#8873)
  Optimize writes to existing Zarr stores. (pydata#8875)
  Allow multidimensional variable with same name as dim when constructing dataset via coords (pydata#8886)
  Don't allow overwriting indexes with region writes (pydata#8877)
  Migrate datatree.py module into xarray.core. (pydata#8789)
  warn and return bytes undecoded in case of UnicodeDecodeError in h5netcdf-backend (pydata#8874)
  groupby: Dispatch quantile to flox. (pydata#8720)
  Opt out of auto creating index variables (pydata#8711)
  Update docs on view / copies (pydata#8744)
  Handle .oindex and .vindex for the PandasMultiIndexingAdapter and PandasIndexingAdapter (pydata#8869)
  numpy 2.0 copy-keyword and trapz vs trapezoid (pydata#8865)
  upstream-dev CI: Fix interp and cumtrapz (pydata#8861)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants