Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger CI only if code files are modified. #9006

Merged
merged 2 commits into from
May 6, 2024
Merged

Trigger CI only if code files are modified. #9006

merged 2 commits into from
May 6, 2024

Conversation

dcherian
Copy link
Contributor

@dcherian dcherian commented May 6, 2024

max-sixty
max-sixty reviewed May 6, 2024
View reviewed changes
.github/workflows/ci-additional.yaml
@@ -6,6 +6,9 @@ on:
pull_request:
branches:
- "main"
paths:
- 'ci/**'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly we could move ci into .github; consolidate some of the top-level paths

@dcherian @max-sixty
Apply suggestions from code review
2b46cdd 
Co-authored-by: Maximilian Roos <5635139+max-sixty@users.noreply.github.com>
@dcherian dcherian merged commit 2ad98b1 into pydata:main May 6, 2024
28 checks passed
@dcherian dcherian deleted the limit-ci branch May 6, 2024 19:21
andersy005 pushed a commit that referenced this pull request May 10, 2024
@dcherian @max-sixty @andersy005
Trigger CI only if code files are modified. (#9006)
becc0bb 
* Trigger CI only if code files are modified.

Fixes #8705

* Apply suggestions from code review

Co-authored-by: Maximilian Roos <5635139+max-sixty@users.noreply.github.com>

---------

Co-authored-by: Maximilian Roos <5635139+max-sixty@users.noreply.github.com>
andersy005 added a commit that referenced this pull request May 10, 2024
@andersy005
Merge branch 'main' into backend-indexing
bfb334c 
* main:
  Avoid auto creation of indexes in concat (#8872)
  Fix benchmark CI (#9013)
  Avoid extra read from disk when creating Pandas Index. (#8893)
  Add a benchmark to monitor performance for large dataset indexing (#9012)
  Zarr: Optimize `region="auto"` detection (#8997)
  Trigger CI only if code files are modified. (#9006)
  Fix for ruff 0.4.3 (#9007)
  Port negative frequency fix for `pandas.date_range` to `cftime_range` (#8999)
  Bump codecov/codecov-action from 4.3.0 to 4.3.1 in the actions group (#9004)
  Speed up localize (#8536)
  Simplify fast path (#9001)
  Add argument check_dims to assert_allclose to allow transposed inputs (#5733) (#8991)
  Fix syntax error in test related to cupy (#9000)
andersy005 pushed a commit that referenced this pull request May 10, 2024
@dcherian @max-sixty @andersy005
Trigger CI only if code files are modified. (#9006)
18c5c70 
* Trigger CI only if code files are modified.

Fixes #8705

* Apply suggestions from code review

Co-authored-by: Maximilian Roos <5635139+max-sixty@users.noreply.github.com>

---------

Co-authored-by: Maximilian Roos <5635139+max-sixty@users.noreply.github.com>
andersy005 added a commit to hmaarrfk/xarray that referenced this pull request May 10, 2024
@andersy005
Merge branch 'backend-indexing' into tuples_backend_indexing
d1edd15 
* backend-indexing:
  Trigger CI only if code files are modified. (pydata#9006)
  Enable explicit use of key tuples (instead of *Indexer objects) in indexing adapters and explicitly indexed arrays (pydata#8870)
  add `.oindex` and `.vindex` to `BackendArray` (pydata#8885)
  temporary enable CI triggers on feature branch
  Avoid auto creation of indexes in concat (pydata#8872)
  Fix benchmark CI (pydata#9013)
  Avoid extra read from disk when creating Pandas Index. (pydata#8893)
  Add a benchmark to monitor performance for large dataset indexing (pydata#9012)
  Zarr: Optimize `region="auto"` detection (pydata#8997)
  Trigger CI only if code files are modified. (pydata#9006)
  Fix for ruff 0.4.3 (pydata#9007)
  Port negative frequency fix for `pandas.date_range` to `cftime_range` (pydata#8999)
  Bump codecov/codecov-action from 4.3.0 to 4.3.1 in the actions group (pydata#9004)
  Speed up localize (pydata#8536)
  Simplify fast path (pydata#9001)
  Add argument check_dims to assert_allclose to allow transposed inputs (pydata#5733) (pydata#8991)
  Fix syntax error in test related to cupy (pydata#9000)
dcherian added a commit to dcherian/xarray that referenced this pull request Jun 10, 2024
@dcherian
Revert "Trigger CI only if code files are modified. (pydata#9006)"
ae9d002 
This reverts commit 2ad98b1.
@dcherian dcherian mentioned this pull request Jun 10, 2024
Merged
dcherian added a commit that referenced this pull request Jun 10, 2024
@dcherian
Always run code tests (#9083)
94c8432 
* Revert "Run tests on changes to root dotfiles (#9062)"

This reverts commit 1f3bc7e.

* Revert "Trigger CI only if code files are modified. (#9006)"

This reverts commit 2ad98b1.
andersy005 pushed a commit that referenced this pull request Jun 14, 2024
@dcherian @andersy005
Always run code tests (#9083)
7009b2a 
* Revert "Run tests on changes to root dotfiles (#9062)"

This reverts commit 1f3bc7e.

* Revert "Trigger CI only if code files are modified. (#9006)"

This reverts commit 2ad98b1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-sixty max-sixty max-sixty left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

More granularity in the CI, separating code and docs changes?
2 participants
@dcherian @max-sixty