Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add utility for opening remote files with fsspec #9797

Merged
merged 8 commits into from
Nov 20, 2024
Merged

Add utility for opening remote files with fsspec #9797

merged 8 commits into from
Nov 20, 2024

Conversation

jrbourbeau
Copy link
Contributor

Supersedes #8424

jrbourbeau
jrbourbeau commented Nov 18, 2024
View reviewed changes
xarray/backends/common.py Outdated Show resolved Hide resolved
@jrbourbeau jrbourbeau mentioned this pull request Nov 18, 2024
Closed
@jrbourbeau jrbourbeau changed the title Add utility for opening remote files with fsspec Add utility for opening remote files with fsspec Nov 18, 2024
jhamman
jhamman approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@jhamman jhamman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good @jrbourbeau. Thanks for separating the open logic into a nice little utility function.

xarray/backends/common.py Outdated Show resolved Hide resolved
xarray/backends/h5netcdf_.py Outdated Show resolved Hide resolved
@kmuehlbauer
Copy link
Contributor

@jrbourbeau Thanks, it looks like we can still use h5py ros-driver by specifying driver="ros3". Great!

@kmuehlbauer
Copy link
Contributor

@jrbourbeau Would you mind adding an entry to whats-new.rst for more visibility?

@jrbourbeau
Copy link
Contributor Author

Yeah, no problem, just added an entry

headtr1ck
headtr1ck approved these changes Nov 20, 2024
View reviewed changes
xarray/backends/h5netcdf_.py Outdated Show resolved Hide resolved
@dcherian dcherian merged commit 077276a into pydata:main Nov 20, 2024
29 checks passed
@jrbourbeau jrbourbeau deleted the open-remote-files branch November 21, 2024 15:06
@jrbourbeau
Copy link
Contributor Author

Thanks all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@headtr1ck headtr1ck headtr1ck approved these changes

@kmuehlbauer kmuehlbauer kmuehlbauer approved these changes

@jhamman jhamman jhamman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jrbourbeau @kmuehlbauer @jhamman @headtr1ck @dcherian