Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Use localhost as the default bind address #719

Merged
merged 1 commit into from
Dec 21, 2021

Conversation

scaramallion
Copy link
Member

@scaramallion scaramallion commented Dec 21, 2021

Reference issue

Closes #680

Tasks

  • Fix or feature added
  • Documentation and examples updated (if relevant)
  • Unit tests passing and coverage at 100% after adding fix/feature

@codecov
Copy link

codecov bot commented Dec 21, 2021

Codecov Report

Merging #719 (fdef419) into master (84a5a20) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #719   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           28        28           
  Lines         8608      8609    +1     
=========================================
+ Hits          8608      8609    +1     
Impacted Files Coverage Δ
pynetdicom/ae.py 100.00% <ø> (ø)
pynetdicom/_globals.py 100.00% <100.00%> (ø)
pynetdicom/transport.py 100.00% <100.00%> (ø)

@scaramallion scaramallion changed the title [WIP] Use localhost as the default bind address [MRG] Use localhost as the default bind address Dec 21, 2021
@scaramallion scaramallion merged commit bc8fd99 into pydicom:master Dec 21, 2021
@scaramallion scaramallion deleted the dev-sock branch December 21, 2021 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LGTM error: Binding a socket to all network interfaces
1 participant