Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problems with pyenv installed via scoop. #606

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

codemee
Copy link

@codemee codemee commented Apr 4, 2024

pyenv installed via scoop cannot install python correctly due to the use of juntionpoints in the scoop shims as discussed here. I fix the problems by getting the real path before executing msiexec program.

  • modified: pyenv-win/libexec/libs/pyenv-install-lib.vbs
    Add a function called getRealPath to get the real path of a path containing junctionpoint.

  • modified: pyenv-win/libexec/pyenv-install.vbs
    Call the function above to get the real path of a cached msi file and the real path of installing target folder.

	modified:   pyenv-win/libexec/libs/pyenv-install-lib.vbs
	Add a function called getRealPath to get the real path of a path containing junctionpoint.

	modified:   pyenv-win/libexec/pyenv-install.vbs
	Call the function above to get the real path of a cached msi file
	and the real path of installing target folder.
@codemee codemee requested a review from a team as a code owner April 4, 2024 05:06
@codemee codemee requested review from Darsstar and kirankotari April 4, 2024 05:06
@kirankotari
Copy link
Member

@codemee will you be able to add test case for it

@codemee
Copy link
Author

codemee commented May 3, 2024

@kirankotari I'm not quite sure what or how to do. Is that you mean to add a test case script to test that modification works, or I should run any test script on my machine to make sure the modification works? Thanks.

@kirankotari kirankotari enabled auto-merge June 20, 2024 19:35
@25077667
Copy link

25077667 commented Aug 6, 2024

Hi @codemee,

I encountered this issue as well.
It appears that the maintainer has enabled the auto-merge feature, but there are some conflicts that need to be resolved. Would you be able to address these conflicts, or would you like me to help resolve them?

@codemee
Copy link
Author

codemee commented Aug 8, 2024

I need your help. Thanks.

Hi @codemee,

I encountered this issue as well. It appears that the maintainer has enabled the auto-merge feature, but there are some conflicts that need to be resolved. Would you be able to address these conflicts, or would you like me to help resolve them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants