Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use virtualenv's (de)activate scripts? #69

Closed
blueyed opened this issue Mar 23, 2015 · 1 comment · Fixed by #104
Closed

Do not use virtualenv's (de)activate scripts? #69

blueyed opened this issue Mar 23, 2015 · 1 comment · Fixed by #104

Comments

@blueyed
Copy link
Collaborator

blueyed commented Mar 23, 2015

There are several issues with the virtualenv's activate script, especially with its handling of $PATH (pypa/virtualenv#722).

Since it's basically rather trivial for what it does, I think it would be a good idea for pyenv-virtualenv to not use it, but do the setup / restoring itself.

Other issues: pypa/virtualenv#724, pypa/virtualenv#723.

@yyuu
Copy link
Collaborator

yyuu commented May 17, 2015

Avoid using the activate script generated by virtualenv is possible. But I think that keep using vanilla virtualenv would be better for compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants