Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update service.py #109

Merged
merged 1 commit into from
Oct 1, 2021
Merged

Update service.py #109

merged 1 commit into from
Oct 1, 2021

Conversation

vinraspa
Copy link
Contributor

@vinraspa vinraspa commented Sep 27, 2021

Add datetime.datetime: "datetime" to ODS_WRITE_FORMAT_COVERSION dict.
This pull request is needed to add datetime.datetime support to pyexcel_ods3 module (pyexcel_ods3/odsw.py).
Thank you

With your PR, here is a check list:

  • Has test cases written?
  • Has all code lines tested?
  • Has make format been run?
  • Please update CHANGELOG.yml(not CHANGELOG.rst)
  • Has fair amount of documentation if your change is complex
  • Agree on NEW BSD License for your contribution

Add datetime.datetime: "datetime" to ODS_WRITE_FORMAT_COVERSION dict
@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2021

Codecov Report

Merging #109 (1b4fde5) into dev (67c111f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #109   +/-   ##
=======================================
  Coverage   97.91%   97.91%           
=======================================
  Files          52       52           
  Lines        3361     3361           
=======================================
  Hits         3291     3291           
  Misses         70       70           
Impacted Files Coverage Δ
pyexcel_io/service.py 97.39% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67c111f...1b4fde5. Read the comment docs.

@chfw chfw merged commit 04f992c into pyexcel:dev Oct 1, 2021
@chfw chfw mentioned this pull request Oct 8, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants