-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cap stability changes with capless modules #126
Comments
Friend reports that offlining / onlining autocannon changes stability from 36.4 to 38.1, which is a bigger change than what was previously noted on Gila above. Look into if this can affect marginally cap stable fits. Also, loading the autocannon with ammo bumps stability from 36.4 to 36.5. =/ Whether or not this is fixed really depends on if there is a use case where a fit is stable but the simulator bugs out and says it's not, or vise versa |
Took a quick look at this since I had 5 minutes to kill. There is something wrong with the cap sim calculation, but I don't know the mechanics of it well enough and don't really have time to delve into the maths of it. However, I do have a quick fix that more or less avoids the problem rather than fixing it, with the end result essentially being the same (commented portion is the actual fix, commentary below):
Pyfa basically takes all active modules and adds them to a cap drain list. When appending, this bit Now, to my knowledge, there is no reason to add cap-less modules to the list. That's where my commented fix comes in, and seems to work as expected. I'll commit this after discussing possible unforeseen side effects with Kadesh In case we want to go into further diagnostics at any time, the deepest I delved into the cap sim was confirming that |
Changed comparison from |
All V skills.
This seems to affect any fit where you have cap and capless modules (another example would be hurricane with web, and adding an autocannon)
The total cap / cap usage stats do not seem to change, only the percentage.
The text was updated successfully, but these errors were encountered: