Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct t3 subsystem export order #130

Closed
blitzmann opened this issue Jun 12, 2014 · 4 comments
Closed

Correct t3 subsystem export order #130

blitzmann opened this issue Jun 12, 2014 · 4 comments

Comments

@blitzmann
Copy link
Collaborator

Apparently EVE cares which order they are presented in:

https://forums.eveonline.com/default.aspx?g=posts&m=4703937#post4703937

Untested and unconfirmed at the moment.

@blitzmann
Copy link
Collaborator Author

I've confirmed that this is indeed an issue. Furthermore, it seems to be a bug on CCPs side, as I cannot fathom why they would allow a fitting to save correctly and show up correctly, but the order that the modules was exported is important.

Affects both DNA (HTML) and XML exports

@blitzmann
Copy link
Collaborator Author

Looked into it, and I'd like to do this properly by modifying the module position when the subsystem is added rather than hacking some kind of sorting into the export code.

Every subsystem has a subSystemSlot attribute, which takes on the following int:

125 - Electronics
126 - Defensive
127 - Engineering
128 - Offensive
129 - Propulsion

Which is also the order in which they need to be placed.

Add these values with the Module module (where definitions of State, Slot, etc already reside) and upon adding a module, check if it's a subsystem and, if so, check for it's proper placement. Disallow module swapping on Subsystems

@blitzmann
Copy link
Collaborator Author

Actually, refreshing my memory on how module positions are set in the backend, to do this 'properly' would require a bit more work than I initially thought. We would have to modify the module appending (which handles assigning positions based on :magic:). I think I'll make a quick fix in just export itself, and in spare time look into making it a bit better by modifying the actual positions (which isn't really required for Pyfa to properly function)

@blitzmann
Copy link
Collaborator Author

(Accidentally closed with commit)

Fixed to my knowledge, however I would like to do a few tests that require access to SISI. Specifically, I want to make sure that location of the subsystems in the DNA export is not specific and only order is (ie, does the client freak out when subsystems come before drones?). For this I will have to use SISI as I do not have any offensive T3s with drones and stuff that I can easily test with on TQ. I'm away from my dev machine atm, so hopefully I'll get around to testing this in the next couple days.

@blitzmann blitzmann reopened this Jun 15, 2014
w9jds pushed a commit to w9jds/Pyfa that referenced this issue Aug 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant