-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Booster not being applied properly (possibly) #63
Comments
On v1.1.22, there does seem to be a bug. Using those fits with
So your method did not show anything strange. However, you state that the improved repping power is applied when projecting the boosted logi fit onto the Oracle. Can you confirm this? Because from what I can see, the bug lies in the fact that the projected fit does not take into account possible boosts on the projected fit. Projecting an unboosted Scythe tot he fit gives me Can you please confirm... |
I just tried again, and now the improved shield reps are being applied... Definitely something going on here, and it's causing a headache even trying to think about it. I'll look into it more deeply in the coming weeks (have some things coming up next few days), but this is probably just one of those broken things with |
Yeah I knew that something was wrong but I could not figure out exactly |
Okay, dug a little more, apparently I did it wrong the first time somehow. Here are my test cases: Open all fits in tabs, and filter ship browser to show them (I named them all ISSUE63)
The code behind this is old and hacked together from what I've read. It does okay with projected and fleet boosting, however I don't think projecting a boosted ship while boosting was considered and tested. From the data gathered, it seems like it keeps missing a step, not applying one or the other. Hopefully it's a simply case of forgetting to calculate new states in a particular spot in the code - question is, where is that spot? Is this even salvageable with the current codebase without significant changes? As stated, I'll look into it, but can't promise anything. tl;dr: it's fucked |
Had some time today to sit down and brood over this. Did some more tests, and I believe I've been able to narrow down where the issue may lie. When the Scythe was boosted and projected onto the Oracle, I noticed that the shield resistances of the Oracle was being raised even when the Oracle was not boosted. I also checked Raw HP (to get the pesky calculations of effective HP out of the way) and performed two tests on an unboosted Oracle: Scythe projection with and without Scythe boosting. The unboosted Scythe shows However, the boosted Scythe shows This, coupled with the fact that the Oracle is receiving resistance boosting when the boosted Scythe is projected, tells me that the Scythe's booster is ignoring the Scythe fit and projecting directly onto the Oracle. Since the projected Scythe is not getting it's boosts, it doesn't project the boosted rep amount. Will continue to look into this. Hopefully this isn't as frustrating of a fix as it looks on first glance. =) |
Continuing with the investigation, there are actually
|
Mde a branch with the four fixes, last commit being: blitzmann@b783f06 I fixed 4 to iterate through projected fits in |
Here's the fits that I'm using:
I have this Scythe fit:
projected to this Oracle fit:
with this Sleipnir as booster on the Scythe:
The text was updated successfully, but these errors were encountered: