-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gang bonus calculation issues when projecting boosting ship onto fit #75
Comments
Possible relation to #63 Haven't really had a chance to look into it yet, and it may be an inherit limitation with the current engine. Projections were hacked together and there are a lot of design flaws with them. I'm hoping against hope it's an easy fix, but... Quick fix may just be to disallow projection of same ship as a booster, and vise versa. I cannot really think of a use case where the same ship would be projected and boosting at the same time... |
The use case for me was carriers and supercarriers with ganglinks and RR. |
As i mentioned multiple times, fleet boosting support is somewhat hackish. I noticed this bug several times and i suppose it is not an easy fix. |
Popping in to confirm that this bug is still present as of v1.3.0. #63 was not the cause of this, but I did notice a similar issue when testing out fixes to that issue. Excerpt from pull request:
This shows us that it doesn't necessarily have to be the same ship being projected / boosting, but it does seem to happen if the same ship is in the chain of projections (if you have I'll investigate this a bit more when I have time, and document some use cases here. |
This should be fixed with latest commit in master (e74e261). If not, please reopen. =) |
As per the subject, there seems to be something going wrong with the calculations when projecting
A -> B
whenB
is being boosted byA
.Examples:
Claymore with Shield Harmonizing Link projects onto unfit Retribution. Then set Claymore as Squad Booster. Notice that Retribution gets no bonuses.
Remove Claymore as booster and projected fit. Set Claymore as Squad Booster. Then project Claymore fit onto Retribution. Notice that Shield Harmonizing bonus is removed. Then remove Claymore from projected fits. Notice that all gang bonuses are removed, despite Claymore still being listed as Sqaud Booster.
The text was updated successfully, but these errors were encountered: