Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preferences not available in standard location in Mac version 1.1.22 #68

Closed
iay opened this issue Apr 3, 2014 · 4 comments
Closed

preferences not available in standard location in Mac version 1.1.22 #68

iay opened this issue Apr 3, 2014 · 4 comments
Assignees

Comments

@iay
Copy link

iay commented Apr 3, 2014

The 1.1.22 release notes had an item "Preferences have had has a face lift with new icons". However, on my Mac, the actual effect seems to be that the Preferences (Cmd+,) option is no longer available at all: the keypress does nothing, and the option is greyed out in the menu.

@blitzmann
Copy link
Collaborator

I cannot reproduce this on my VM.

Can you produce a screenshot? If you run it from the source, do you get any output?

You're statement is also confusing. Preferences are opened with Cmd+P, not Cmd+,. And I'm not aware of anything disabling the option. Is it available in the Window menu?

@blitzmann blitzmann self-assigned this Apr 3, 2014
@iay
Copy link
Author

iay commented Apr 3, 2014

OK, I understand now. Yes, pyfa 1.1.22 does implement the preferences selection as Cmd+P, and that does appear in the Window menu. I must have found it there before at some point.

However, that's contrary to the Mac OS user interface guidelines. Mac users expect preferences to be invoked by Cmd+, and expect to find that under the application menu.

Here's a screenshot showing how pyfa currently behaves: you can see that there is a Preferences option in the application menu, and it is assigned to Cmd+, but greyed out.

screen shot 2014-04-03 at 18 47 19

It would be a convenience for Mac users if you could bind the preferences to Cmd+, as well as to Cmd+P. I'll rename the issue.

@iay iay changed the title preferences no longer available in Mac version 1.1.22 preferences not available in standard location in Mac version 1.1.22 Apr 3, 2014
@blitzmann
Copy link
Collaborator

Thanks for the info. You can probbly tell we're not mac users lol. I'll fix this soon =)

@blitzmann
Copy link
Collaborator

Fixed with 23e6331. It's in the application menu now, but also still in the Window menu for :reasons:. Hope this helps, should be out in the next release (if you want it now, apply changes in commit to pyfa package)

=)

Ebag333 added a commit to Ebag333/Pyfa that referenced this issue Apr 27, 2017
Enhancement: User Updatable Database
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants