-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MultiAggregation
and aggregation_resolver
#4749
Conversation
MessagePassing
with nn.aggr
building blocks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. This mostly looks good to me, and I left a few comments.
Notably, this PR groups a bunch of separate functionality (MulAggregation
, MultiAggregation
, MessagePassing
integration, ...) into a single PR, which makes it overly complex. Next time, I think we should work on separating these functionalities into separate PRs to ease reviewing.
Thanks for the helpful comments @rusty1s! The PR is ready for another review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me so far. Happy to review again once no longer WIP.
MessagePassing
with nn.aggr
building blocksMessagePassing
with nn.aggr
building blocks
MessagePassing
with nn.aggr
building blocksMultiAggregation
and aggregation_resolver
Thanks @lightaime. In favor of smaller PRs, I removed the |
Codecov Report
@@ Coverage Diff @@
## master #4749 +/- ##
==========================================
- Coverage 84.39% 82.53% -1.87%
==========================================
Files 324 325 +1
Lines 17332 17369 +37
==========================================
- Hits 14628 14336 -292
- Misses 2704 3033 +329
Continue to review full report at Codecov.
|
MulAggregation
,MultiAggregation
andaggregation_resolver