Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiAggregation and aggregation_resolver #4749

Merged
merged 21 commits into from
Jun 7, 2022
Merged

MultiAggregation and aggregation_resolver #4749

merged 21 commits into from
Jun 7, 2022

Conversation

lightaime
Copy link
Contributor

@lightaime lightaime commented Jun 1, 2022

  • Add MulAggregation, MultiAggregation and aggregation_resolver

@rusty1s rusty1s changed the title [WIP] MessagePassing with nn.aggr package [WIP] MessagePassing with nn.aggr building blocks Jun 2, 2022
Copy link
Member

@rusty1s rusty1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. This mostly looks good to me, and I left a few comments.

Notably, this PR groups a bunch of separate functionality (MulAggregation, MultiAggregation, MessagePassing integration, ...) into a single PR, which makes it overly complex. Next time, I think we should work on separating these functionalities into separate PRs to ease reviewing.

test/nn/aggr/test_basic.py Show resolved Hide resolved
test/nn/aggr/test_basic.py Outdated Show resolved Hide resolved
test/nn/aggr/test_mp_interface.py Outdated Show resolved Hide resolved
test/nn/aggr/test_mp_interface.py Outdated Show resolved Hide resolved
torch_geometric/nn/aggr/__init__.py Outdated Show resolved Hide resolved
torch_geometric/nn/aggr/multi.py Show resolved Hide resolved
torch_geometric/nn/conv/message_passing.py Outdated Show resolved Hide resolved
torch_geometric/nn/conv/message_passing.py Outdated Show resolved Hide resolved
torch_geometric/nn/conv/message_passing.py Outdated Show resolved Hide resolved
torch_geometric/nn/conv/message_passing.py Outdated Show resolved Hide resolved
@lightaime lightaime requested a review from Padarn June 4, 2022 08:24
@lightaime
Copy link
Contributor Author

Thanks for the helpful comments @rusty1s! The PR is ready for another review.

Copy link
Contributor

@Padarn Padarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me so far. Happy to review again once no longer WIP.

@rusty1s rusty1s marked this pull request as ready for review June 7, 2022 10:29
@rusty1s rusty1s changed the title [WIP] MessagePassing with nn.aggr building blocks MessagePassing with nn.aggr building blocks Jun 7, 2022
@rusty1s rusty1s changed the title MessagePassing with nn.aggr building blocks MultiAggregation and aggregation_resolver Jun 7, 2022
@rusty1s rusty1s mentioned this pull request Jun 7, 2022
26 tasks
@rusty1s
Copy link
Member

rusty1s commented Jun 7, 2022

Thanks @lightaime. In favor of smaller PRs, I removed the MessagePassing integration such that this PR solely adds support for MulAggregation, MultiAggregation and aggregation_resolver. Can you please re-send your modifications in message_passing.py and test_message_passing.py in a separate PR? Here is the last commit: https://github.com/pyg-team/pytorch_geometric/tree/2b1ac91569c4ea4de2b603e883e6e831cc2c0c0e

@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #4749 (325143b) into master (893aca5) will decrease coverage by 1.86%.
The diff coverage is 97.87%.

@@            Coverage Diff             @@
##           master    #4749      +/-   ##
==========================================
- Coverage   84.39%   82.53%   -1.87%     
==========================================
  Files         324      325       +1     
  Lines       17332    17369      +37     
==========================================
- Hits        14628    14336     -292     
- Misses       2704     3033     +329     
Impacted Files Coverage Δ
torch_geometric/nn/resolver.py 90.00% <93.33%> (-5.46%) ⬇️
torch_geometric/nn/aggr/__init__.py 100.00% <100.00%> (ø)
torch_geometric/nn/aggr/basic.py 100.00% <100.00%> (ø)
torch_geometric/nn/aggr/multi.py 100.00% <100.00%> (ø)
torch_geometric/nn/models/dimenet_utils.py 0.00% <0.00%> (-75.52%) ⬇️
torch_geometric/nn/models/dimenet.py 14.51% <0.00%> (-53.00%) ⬇️
torch_geometric/nn/conv/utils/typing.py 81.25% <0.00%> (-17.50%) ⬇️
torch_geometric/nn/inits.py 67.85% <0.00%> (-7.15%) ⬇️
torch_geometric/io/tu.py 93.90% <0.00%> (-2.44%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 893aca5...325143b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants