-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sampling according to max_sample
within AddMetaPaths
#4750
Conversation
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #4750 +/- ##
==========================================
- Coverage 84.37% 82.48% -1.90%
==========================================
Files 324 324
Lines 17304 17313 +9
==========================================
- Hits 14601 14281 -320
- Misses 2703 3032 +329
Continue to review full report at Codecov.
|
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
max_sample
within AddMetaPaths
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @RexYing. This mostly looks good. I think edge_index_sampling
should leverage SparseTensor
to make this a little bit faster and to ensure that we are always operating on sorted inputs.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
I think I fixed the runtime issues. One reason for this was that it is quite expensive to sample in both directions. I don't think this is really needed, and I moved to a solution where we only sample |
This functionality is used in cases where certain metapath edge types result in very dense adjacency.
If
max_sample
is set, in expectation this number of samples will be sampled per node for each edge index.