-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LinkNeighborLoader
to Pytorch Lightning datamodule
#4868
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4868 +/- ##
==========================================
- Coverage 82.76% 82.62% -0.14%
==========================================
Files 329 329
Lines 17709 17748 +39
==========================================
+ Hits 14656 14665 +9
- Misses 3053 3083 +30
Continue to review full report at Codecov.
|
LinkNeighborLoader
to Pytorch Lightning datamodule
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ar104 I think this generally looks good although I would prefer to move this functionality to its own module, e.g., LightningLinkData
. Otherwise, I feel the interface of input_nodes
might become a bit confusing to you. WDYT?
for more information, see https://pre-commit.ci
…geometric into edge_lightning
Done. |
input_train_edges: InputEdges = None, | ||
input_val_edges: InputEdges = None, | ||
input_test_edges: InputEdges = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's unclear what would happen when train/test/val edges are None
. If input_val_edges
or input_test_edges
are None
then all edges would be considered.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1. I would be okay to make them required for now, and add a TODO to revisit this later on.
input_train_edges: InputEdges = None, | ||
input_val_edges: InputEdges = None, | ||
input_test_edges: InputEdges = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1. I would be okay to make them required for now, and add a TODO to revisit this later on.
Co-authored-by: Jinu Sunil <jinu.sunil@gmail.com>
Co-authored-by: Jinu Sunil <jinu.sunil@gmail.com>
Extend the pytorch lightning datamodule to support wrapping the link neighbor loader.