Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add profiling support for benchmark/kernel and benchmark/inference #5073

Merged
merged 24 commits into from
Aug 24, 2022
Merged

Add profiling support for benchmark/kernel and benchmark/inference #5073

merged 24 commits into from
Aug 24, 2022

Conversation

yanbing-j
Copy link
Contributor

@yanbing-j yanbing-j commented Jul 28, 2022 •
edited
Loading

Adding inference test in benchmark/kernel.
Add profile in benchmark/inference.

@codecov
Copy link

codecov bot commented Jul 28, 2022 •
edited
Loading

Codecov Report

Merging #5073 (872cdec) into master (b2d7f09) will decrease coverage by 0.00%.
The diff coverage is 43.47%.

@@            Coverage Diff             @@
##           master    #5073      +/-   ##
==========================================
- Coverage   83.15%   83.15%   -0.01%     
==========================================
  Files         337      337              
  Lines       18581    18591      +10     
==========================================
+ Hits        15451    15459       +8     
- Misses       3130     3132       +2
Impacted Files Coverage Δ
torch_geometric/profile/profile.py 37.89% <40.90%> (+4.95%) ⬆️
torch_geometric/profile/__init__.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yanbing-j yanbing-j requested a review from rusty1s July 28, 2022 07:50
lightaime
lightaime reviewed Jul 28, 2022
View reviewed changes
Copy link
Contributor

@lightaime lightaime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good! Left some minor comments.

benchmark/kernel/gcn-ogbn.py Outdated Show resolved Hide resolved
benchmark/kernel/main_performance.py Outdated Show resolved Hide resolved
benchmark/kernel/main_performance.py Show resolved Hide resolved
@yanbing-j yanbing-j requested a review from lightaime July 29, 2022 07:22
@rusty1s rusty1s changed the title [Benchmark] Add inference test and add gcn+ognb-products for benchmark/kernel Add inference benchmark fore GCN+ognb-products Jul 30, 2022
lightaime
lightaime approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@lightaime lightaime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks @yanbing-j. Left some final small comments.

benchmark/kernel/gcn-ogbn.py Outdated Show resolved Hide resolved
benchmark/kernel/main_performance.py Show resolved Hide resolved
@lightaime
Copy link
Contributor

Thanks @yanbing-j. LGTM!

@yanbing-j
Copy link
Contributor Author

Thanks @yanbing-j. LGTM!

Thanks @lightaime . Could you please help merge this PR?

@rusty1s rusty1s changed the title Add inference benchmark fore GCN+ognb-products Add inference benchmark for GCN+ognb-products Aug 7, 2022
rusty1s
rusty1s reviewed Aug 7, 2022
View reviewed changes
benchmark/kernel/train_eval.py Outdated Show resolved Hide resolved
benchmark/kernel/gcn-ogbn.py Outdated Show resolved Hide resolved
benchmark/kernel/gcn-ogbn.py Outdated Show resolved Hide resolved
benchmark/kernel/gcn-ogbn.py Outdated Show resolved Hide resolved
benchmark/kernel/gcn-ogbn.py Outdated Show resolved Hide resolved
benchmark/kernel/gcn-ogbn.py Outdated Show resolved Hide resolved
benchmark/kernel/gcn-ogbn.py Outdated Show resolved Hide resolved
benchmark/kernel/gcn-ogbn.py Outdated Show resolved Hide resolved
torch_geometric/profile/profile.py Outdated Show resolved Hide resolved
torch_geometric/profile/profile.py Outdated Show resolved Hide resolved
@rusty1s rusty1s changed the title Add inference benchmark for GCN+ognb-products Add inference benchmark for GCN+ogbn-products Aug 8, 2022
@yanbing-j yanbing-j requested a review from rusty1s August 11, 2022 06:58
@yanbing-j yanbing-j changed the title Add inference benchmark for GCN+ogbn-products Add profiling support for benchmark/kernel and benchmark/inference Aug 11, 2022
Padarn
Padarn requested changes Aug 13, 2022
View reviewed changes
torch_geometric/profile/profile.py Outdated Show resolved Hide resolved
@yanbing-j yanbing-j requested a review from Padarn August 15, 2022 02:06
rusty1s
rusty1s reviewed Aug 24, 2022
View reviewed changes
benchmark/citation/train_eval.py Show resolved Hide resolved
benchmark/inference/utils.py Outdated Show resolved Hide resolved
benchmark/kernel/main_performance.py Outdated Show resolved Hide resolved
benchmark/kernel/main_performance.py Show resolved Hide resolved
benchmark/kernel/main_performance.py Outdated Show resolved Hide resolved
benchmark/kernel/train_eval.py Show resolved Hide resolved
torch_geometric/profile/profile.py Outdated Show resolved Hide resolved
torch_geometric/profile/profile.py Outdated Show resolved Hide resolved
rusty1s
rusty1s approved these changes Aug 24, 2022
View reviewed changes
benchmark/inference/utils.py Outdated Show resolved Hide resolved
benchmark/kernel/train_eval.py Outdated Show resolved Hide resolved
@rusty1s rusty1s merged commit c875fc9 into pyg-team:master Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusty1s rusty1s rusty1s approved these changes

@lightaime lightaime lightaime approved these changes

@Padarn Padarn Awaiting requested review from Padarn

Assignees

@yanbing-j yanbing-j

Labels
0 - Priority P0 benchmark feature skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yanbing-j @lightaime @Padarn @rusty1s